feat: Query timeout #165
Merged
feat: Query timeout #165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sciator
force-pushed
the
164-query-execution-stops-and-code-exits-without-throwing-any-error
branch
from
1ae4c26 to
41f1b8e
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #165 +/- ##
=======================================
Coverage 95.99% 95.99%
=======================================
Files 22 22
Lines 848 848
Branches 198 198
=======================================
Hits 814 814
Misses 9 9
Partials 25 25 ☔ View full report in Codecov by Sentry. |
bednar
previously requested changes
Nov 14, 2023
There was a problem hiding this comment.
The client currently encounters issues with data retrieval and error propagation. Please prioritize testing and implementation in these specific scenarios:
- Execute scripts multiple times. The results should display immediately without the need for setting a timeout.
- Introduce invalid SQL in scripts. Then, run these scripts multiple times to ensure that the error is consistently and correctly propagated.
- Execute scripts in parallel and verify that both results and errors are accurately displayed.
Sciator
force-pushed
the
164-query-execution-stops-and-code-exits-without-throwing-any-error
branch
from
639c506 to
6717e1e
Compare
bednar
requested changes
Nov 16, 2023
Co-authored-by: Jakub Bednář <[email protected]>
bednar
approved these changes
Nov 16, 2023
bednar
deleted the
164-query-execution-stops-and-code-exits-without-throwing-any-error
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #164
Proposed Changes
stream timeout for query (grpc timeout)
Checklist