Improving Test Reliability in RemoteTemporaryDirectory and TestJobManager #452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
herve-er
changed the title
|
ClementKunz
reviewed
Jan 3, 2025
|
|
||
| cancelAllOngoingJobs(); | ||
|
|
||
| Utility::msleep(10000); // Wait 10sec | ||
| int rerty = 1000; // Wait max 10sec |
ClementKunz
reviewed
Jan 3, 2025
| size_t total = data->size(); | ||
| CPPUNIT_ASSERT(jobCounter != total); | ||
| CPPUNIT_ASSERT(total > 0); | ||
| size_t uploadedFileCounter = data->size(); |
ClementKunz
reviewed
Jan 3, 2025
| _dirId = dataObj->get(idKey).toString(); | ||
| const std::string& testType /*= "undef"*/) : | ||
| _driveDbId(driveDbId) { | ||
| std::string suffix = CommonUtility::generateRandomStringAlphaNum(5); |
There was a problem hiding this comment.
Not an issue but you can put this into the loop so you won't need to call it again on line 46.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue 1: Naming Conflicts in
RemoteTemporaryDirectoryRemoteTemporaryDirectorycan encounter aFileAlreadyExisterror due to naming conflicts in the following scenarios:Solution:
Issue 2: Flaky Test in
TestJobManager::testCancelJobsThe
TestJobManager::testCancelJobstest could fail randomly due to:Solution:
jobManagerqueue to empty.This change not only improves test reliability but also reduces test execution time, eliminating the need for an arbitrary 11-second wait.
Issue 3: Flaky Test in testLog::testExpiredLogFiles
testLog::testExpiredLogFiles could fail randomly due to timing issues caused by too short wait for log expiration.
Solution:
Increased the time interval for log expiration to ensure adequate margin for the test environment. This change ensures stability and eliminates random failures.