fix: incorrect version passed to the main workflow

Informatievlaanderen · Sep 30, 2024 · 0034c9b · 0034c9b
1 parent 0caa3a6
commit 0034c9b
Showing 1 changed file with 6 additions and 26 deletions.
diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml
@@ -444,7 +444,7 @@ jobs:
         uses: informatievlaanderen/awscurl-polling-action/polling-action@deploy-v4
         with:
           environment: test
-          version: ${{ github.event.inputs.version }}
+          version: ${{ needs.release.outputs.version }}
           status-url: $STATUS_URL
           deploy-url: $BUILD_URL
           access-key: ${{ secrets.AWS_ACCESS_KEY_ID }}
@@ -462,6 +462,7 @@ jobs:
           echo Status: ${{ steps.awscurl-polling-action.outputs.status }}
           echo ${{ steps.awscurl-polling-action.outputs.final-message }}
 
+
   upload-mutationfile-lambda:
     name: Upload MutationFile Lambda
     needs: [ release ]
@@ -502,13 +503,6 @@ jobs:
     runs-on: ubuntu-latest
 
     steps:
-      - name: CD Lambda(s) Configure credentials
-        uses: aws-actions/configure-aws-credentials@v4
-        with:
-          aws-access-key-id: ${{ secrets.AWS_ACCESS_KEY_ID }}
-          aws-secret-access-key: ${{ secrets.AWS_SECRET_ACCESS_KEY }}
-          aws-region: ${{ secrets.VBR_AWS_REGION_PRD }}
-
       - name: CD
         id: awscurl-polling-action
         env:
@@ -517,7 +511,7 @@ jobs:
         uses: informatievlaanderen/awscurl-polling-action/polling-action@deploy-v4
         with:
           environment: test
-          version: ${{ github.event.inputs.version }}
+          version: ${{ needs.release.outputs.version }}
           status-url: $STATUS_URL
           deploy-url: $BUILD_URL
           access-key: ${{ secrets.AWS_ACCESS_KEY_ID }}
@@ -535,6 +529,7 @@ jobs:
           echo Status: ${{ steps.awscurl-polling-action.outputs.status }}
           echo ${{ steps.awscurl-polling-action.outputs.final-message }}
 
+
   upload-sync-lambda:
     name: Upload Sync Lambda
     needs: [ release ]
@@ -575,22 +570,6 @@ jobs:
     runs-on: ubuntu-latest
 
     steps:
-      - name: CD Lambda(s) Configure credentials
-        uses: aws-actions/configure-aws-credentials@v4
-        with:
-          aws-access-key-id: ${{ secrets.AWS_ACCESS_KEY_ID }}
-          aws-secret-access-key: ${{ secrets.AWS_SECRET_ACCESS_KEY }}
-          aws-region: ${{ secrets.VBR_AWS_REGION_PRD }}
-
-      - name: Prepare Lambda
-        shell: bash
-        run: |
-          aws s3 cp s3://$S3_BUCKETNAME_DEVOPS/$VERSION/lambda.zip s3://$S3_BUCKETNAME_TEST/lambda.zip --copy-props none
-        env:
-          S3_BUCKETNAME_DEVOPS: 's3-verenigingsregister-lam-kbo-sync-460116816372'
-          S3_BUCKETNAME_TEST: 's3-verenigingsregister-lam-kbo-sync-716164567317'
-          VERSION: ${{ needs.release.outputs.version }}
-
       - name: CD
         id: awscurl-polling-action
         env:
@@ -599,7 +578,7 @@ jobs:
         uses: informatievlaanderen/awscurl-polling-action/polling-action@deploy-v4
         with:
           environment: test
-          version: ${{ github.event.inputs.version }}
+          version: ${{ needs.release.outputs.version }}
           status-url: $STATUS_URL
           deploy-url: $BUILD_URL
           access-key: ${{ secrets.AWS_ACCESS_KEY_ID }}
@@ -617,6 +596,7 @@ jobs:
           echo Status: ${{ steps.awscurl-polling-action.outputs.status }}
           echo ${{ steps.awscurl-polling-action.outputs.final-message }}
 
+
   publish_to_atlassian:
     if: needs.release.outputs.version != 'none'
     needs: