Skip to content

fix: or-1894 return bad request instead of server error when scroll timed out #874

fix: or-1894 return bad request instead of server error when scroll timed out

fix: or-1894 return bad request instead of server error when scroll timed out #874

Triggered via pull request August 19, 2024 13:33
Status Success
Total duration 8m 34s
Artifacts

pre-merge-tests.yml

on: pull_request
Matrix: Run Tests
Build Angular site
4m 1s
Build Angular site
Build Vue Site
6m 17s
Build Vue Site
Notify Slack of Success
2s
Notify Slack of Success
Notify Slack of Failure
0s
Notify Slack of Failure
Fit to window
Zoom out
Zoom in

Annotations

100 warnings
Build Angular site
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3, actions/cache@v3, actions/setup-node@v3, actions/setup-dotnet@v3, actions/setup-python@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
Run Tests (test/OrganisationRegistry.UnitTests)
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3, actions/cache@v3, actions/setup-dotnet@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
Run Tests (test/OrganisationRegistry.UnitTests)
Possible null reference argument for parameter 'code' in 'MagdaLegalEntityType.MagdaLegalEntityType(string code, string description)'.
Run Tests (test/OrganisationRegistry.UnitTests)
Possible null reference argument for parameter 'description' in 'MagdaLegalEntityType.MagdaLegalEntityType(string code, string description)'.
Run Tests (test/OrganisationRegistry.UnitTests)
Non-nullable field '_eventProcessor' must contain a non-null value when exiting constructor. Consider declaring the field as nullable.
Run Tests (test/OrganisationRegistry.UnitTests)
Dereference of a possibly null reference.
Run Tests (test/OrganisationRegistry.UnitTests)
The field 'OrganisationSearchTests.lastLocationEvent' is never used
Run Tests (test/OrganisationRegistry.UnitTests)
The field 'OrganisationSearchTests._eventProcessor' is never used
Run Tests (test/OrganisationRegistry.UnitTests)
The literal or constant value "search_phase_execution_exception" should be passed as the 'expected' argument in the call to 'Assert.Equal(expected, actual)' in method 'ElasticSearchClient_Search_With_Scroll_Timedout_Does_Not_Throw_Exception' on type 'OrganisationSearchTests'.
Run Tests (test/OrganisationRegistry.UnitTests)
'OrganisationTerminated.OrganisationTerminated(Guid, string, string, DateTime, FieldsToTerminate, KboFieldsToTerminate, bool, DateTime?)' is obsolete: 'Use OrganisationTerminatedV2 instead.'
Run Tests (test/OrganisationRegistry.UnitTests)
Possible null reference argument for parameter 'code' in 'MagdaLegalEntityType.MagdaLegalEntityType(string code, string description)'.
Run Tests (test/OrganisationRegistry.UnitTests): src/OrganisationRegistry.Api/Infrastructure/Magda/MagdaOrganisationResponse.cs#L73
Possible null reference argument for parameter 'description' in 'MagdaLegalEntityType.MagdaLegalEntityType(string code, string description)'.
Run Tests (test/OrganisationRegistry.UnitTests): src/OrganisationRegistry.Api/Infrastructure/Magda/MagdaOrganisationResponse.cs#L73
Possible null reference argument for parameter 'code' in 'MagdaLegalEntityType.MagdaLegalEntityType(string code, string description)'.
Run Tests (test/OrganisationRegistry.UnitTests): src/OrganisationRegistry.Api/Infrastructure/Magda/MagdaOrganisationResponse.cs#L73
Possible null reference argument for parameter 'description' in 'MagdaLegalEntityType.MagdaLegalEntityType(string code, string description)'.
Run Tests (test/OrganisationRegistry.KboMutations.UnitTests)
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3, actions/cache@v3, actions/setup-dotnet@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
Run Tests (test/OrganisationRegistry.KboMutations.UnitTests)
Possible null reference argument for parameter 'code' in 'MagdaLegalEntityType.MagdaLegalEntityType(string code, string description)'.
Run Tests (test/OrganisationRegistry.KboMutations.UnitTests)
Possible null reference argument for parameter 'description' in 'MagdaLegalEntityType.MagdaLegalEntityType(string code, string description)'.
Run Tests (test/OrganisationRegistry.KboMutations.UnitTests)
'OrganisationTerminated.OrganisationTerminated(Guid, string, string, DateTime, FieldsToTerminate, KboFieldsToTerminate, bool, DateTime?)' is obsolete: 'Use OrganisationTerminatedV2 instead.'
Run Tests (test/OrganisationRegistry.KboMutations.UnitTests)
Non-nullable field '_eventProcessor' must contain a non-null value when exiting constructor. Consider declaring the field as nullable.
Run Tests (test/OrganisationRegistry.KboMutations.UnitTests)
Dereference of a possibly null reference.
Run Tests (test/OrganisationRegistry.KboMutations.UnitTests)
The field 'OrganisationSearchTests._eventProcessor' is never used
Run Tests (test/OrganisationRegistry.KboMutations.UnitTests)
The field 'OrganisationSearchTests.lastLocationEvent' is never used
Run Tests (test/OrganisationRegistry.KboMutations.UnitTests)
The literal or constant value "search_phase_execution_exception" should be passed as the 'expected' argument in the call to 'Assert.Equal(expected, actual)' in method 'ElasticSearchClient_Search_With_Scroll_Timedout_Does_Not_Throw_Exception' on type 'OrganisationSearchTests'.
Run Tests (test/OrganisationRegistry.KboMutations.UnitTests)
Possible null reference argument for parameter 'code' in 'MagdaLegalEntityType.MagdaLegalEntityType(string code, string description)'.
Run Tests (test/OrganisationRegistry.KboMutations.UnitTests): src/OrganisationRegistry.Api/Infrastructure/Magda/MagdaOrganisationResponse.cs#L73
Possible null reference argument for parameter 'description' in 'MagdaLegalEntityType.MagdaLegalEntityType(string code, string description)'.
Run Tests (test/OrganisationRegistry.KboMutations.UnitTests): src/OrganisationRegistry.Api/Infrastructure/Magda/MagdaOrganisationResponse.cs#L73
Possible null reference argument for parameter 'code' in 'MagdaLegalEntityType.MagdaLegalEntityType(string code, string description)'.
Run Tests (test/OrganisationRegistry.KboMutations.UnitTests): src/OrganisationRegistry.Api/Infrastructure/Magda/MagdaOrganisationResponse.cs#L73
Possible null reference argument for parameter 'description' in 'MagdaLegalEntityType.MagdaLegalEntityType(string code, string description)'.
Run Tests (test/OrganisationRegistry.ElasticSearch.Tests)
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3, actions/cache@v3, actions/setup-dotnet@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
Run Tests (test/OrganisationRegistry.ElasticSearch.Tests): src/OrganisationRegistry.Api/Infrastructure/Magda/MagdaOrganisationResponse.cs#L73
Possible null reference argument for parameter 'code' in 'MagdaLegalEntityType.MagdaLegalEntityType(string code, string description)'.
Run Tests (test/OrganisationRegistry.ElasticSearch.Tests): src/OrganisationRegistry.Api/Infrastructure/Magda/MagdaOrganisationResponse.cs#L73
Possible null reference argument for parameter 'description' in 'MagdaLegalEntityType.MagdaLegalEntityType(string code, string description)'.
Run Tests (test/OrganisationRegistry.ElasticSearch.Tests): test/OrganisationRegistry.ElasticSearch.Tests/OrganisationSearchTests.cs#L39
Non-nullable field '_eventProcessor' must contain a non-null value when exiting constructor. Consider declaring the field as nullable.
Run Tests (test/OrganisationRegistry.ElasticSearch.Tests): test/OrganisationRegistry.ElasticSearch.Tests/OrganisationSearchTests.cs#L66
The literal or constant value "search_phase_execution_exception" should be passed as the 'expected' argument in the call to 'Assert.Equal(expected, actual)' in method 'ElasticSearchClient_Search_With_Scroll_Timedout_Does_Not_Throw_Exception' on type 'OrganisationSearchTests'.
Run Tests (test/OrganisationRegistry.ElasticSearch.Tests)
Possible null reference argument for parameter 'code' in 'MagdaLegalEntityType.MagdaLegalEntityType(string code, string description)'.
Run Tests (test/OrganisationRegistry.ElasticSearch.Tests)
Possible null reference argument for parameter 'description' in 'MagdaLegalEntityType.MagdaLegalEntityType(string code, string description)'.
Run Tests (test/OrganisationRegistry.ElasticSearch.Tests)
Non-nullable field '_eventProcessor' must contain a non-null value when exiting constructor. Consider declaring the field as nullable.
Run Tests (test/OrganisationRegistry.ElasticSearch.Tests)
Dereference of a possibly null reference.
Run Tests (test/OrganisationRegistry.ElasticSearch.Tests)
The field 'OrganisationSearchTests._eventProcessor' is never used
Run Tests (test/OrganisationRegistry.ElasticSearch.Tests)
The field 'OrganisationSearchTests.lastLocationEvent' is never used
Run Tests (test/OrganisationRegistry.ElasticSearch.Tests)
The literal or constant value "search_phase_execution_exception" should be passed as the 'expected' argument in the call to 'Assert.Equal(expected, actual)' in method 'ElasticSearchClient_Search_With_Scroll_Timedout_Does_Not_Throw_Exception' on type 'OrganisationSearchTests'.
Run Tests (test/OrganisationRegistry.ElasticSearch.Tests)
'OrganisationTerminated.OrganisationTerminated(Guid, string, string, DateTime, FieldsToTerminate, KboFieldsToTerminate, bool, DateTime?)' is obsolete: 'Use OrganisationTerminatedV2 instead.'
Run Tests (test/OrganisationRegistry.ElasticSearch.Tests)
Possible null reference argument for parameter 'code' in 'MagdaLegalEntityType.MagdaLegalEntityType(string code, string description)'.
Run Tests (test/OrganisationRegistry.ElasticSearch.Tests): src/OrganisationRegistry.Api/Infrastructure/Magda/MagdaOrganisationResponse.cs#L73
Possible null reference argument for parameter 'description' in 'MagdaLegalEntityType.MagdaLegalEntityType(string code, string description)'.
Run Tests (test/OrganisationRegistry.Api.IntegrationTests)
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3, actions/cache@v3, actions/setup-dotnet@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
Run Tests (test/OrganisationRegistry.Api.IntegrationTests): src/OrganisationRegistry.Api/Infrastructure/Magda/MagdaOrganisationResponse.cs#L73
Possible null reference argument for parameter 'code' in 'MagdaLegalEntityType.MagdaLegalEntityType(string code, string description)'.
Run Tests (test/OrganisationRegistry.Api.IntegrationTests): src/OrganisationRegistry.Api/Infrastructure/Magda/MagdaOrganisationResponse.cs#L73
Possible null reference argument for parameter 'description' in 'MagdaLegalEntityType.MagdaLegalEntityType(string code, string description)'.
Run Tests (test/OrganisationRegistry.Api.IntegrationTests)
Possible null reference argument for parameter 'code' in 'MagdaLegalEntityType.MagdaLegalEntityType(string code, string description)'.
Run Tests (test/OrganisationRegistry.Api.IntegrationTests)
Possible null reference argument for parameter 'description' in 'MagdaLegalEntityType.MagdaLegalEntityType(string code, string description)'.
Run Tests (test/OrganisationRegistry.Api.IntegrationTests)
Non-nullable field '_eventProcessor' must contain a non-null value when exiting constructor. Consider declaring the field as nullable.
Run Tests (test/OrganisationRegistry.Api.IntegrationTests)
Dereference of a possibly null reference.
Run Tests (test/OrganisationRegistry.Api.IntegrationTests)
The field 'OrganisationSearchTests._eventProcessor' is never used
Run Tests (test/OrganisationRegistry.Api.IntegrationTests)
The field 'OrganisationSearchTests.lastLocationEvent' is never used
Run Tests (test/OrganisationRegistry.Api.IntegrationTests)
The literal or constant value "search_phase_execution_exception" should be passed as the 'expected' argument in the call to 'Assert.Equal(expected, actual)' in method 'ElasticSearchClient_Search_With_Scroll_Timedout_Does_Not_Throw_Exception' on type 'OrganisationSearchTests'.
Run Tests (test/OrganisationRegistry.Api.IntegrationTests)
'OrganisationTerminated.OrganisationTerminated(Guid, string, string, DateTime, FieldsToTerminate, KboFieldsToTerminate, bool, DateTime?)' is obsolete: 'Use OrganisationTerminatedV2 instead.'
Run Tests (test/OrganisationRegistry.Api.IntegrationTests)
Possible null reference argument for parameter 'code' in 'MagdaLegalEntityType.MagdaLegalEntityType(string code, string description)'.
Run Tests (test/OrganisationRegistry.Api.IntegrationTests): src/OrganisationRegistry.Api/Infrastructure/Magda/MagdaOrganisationResponse.cs#L73
Possible null reference argument for parameter 'description' in 'MagdaLegalEntityType.MagdaLegalEntityType(string code, string description)'.
Run Tests (test/OrganisationRegistry.SqlServer.IntegrationTests)
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3, actions/cache@v3, actions/setup-dotnet@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
Run Tests (test/OrganisationRegistry.SqlServer.IntegrationTests)
Possible null reference argument for parameter 'code' in 'MagdaLegalEntityType.MagdaLegalEntityType(string code, string description)'.
Run Tests (test/OrganisationRegistry.SqlServer.IntegrationTests)
Possible null reference argument for parameter 'description' in 'MagdaLegalEntityType.MagdaLegalEntityType(string code, string description)'.
Run Tests (test/OrganisationRegistry.SqlServer.IntegrationTests)
'OrganisationTerminated.OrganisationTerminated(Guid, string, string, DateTime, FieldsToTerminate, KboFieldsToTerminate, bool, DateTime?)' is obsolete: 'Use OrganisationTerminatedV2 instead.'
Run Tests (test/OrganisationRegistry.SqlServer.IntegrationTests)
Non-nullable field '_eventProcessor' must contain a non-null value when exiting constructor. Consider declaring the field as nullable.
Run Tests (test/OrganisationRegistry.SqlServer.IntegrationTests)
Dereference of a possibly null reference.
Run Tests (test/OrganisationRegistry.SqlServer.IntegrationTests)
The field 'OrganisationSearchTests._eventProcessor' is never used
Run Tests (test/OrganisationRegistry.SqlServer.IntegrationTests)
The field 'OrganisationSearchTests.lastLocationEvent' is never used
Run Tests (test/OrganisationRegistry.SqlServer.IntegrationTests)
The literal or constant value "search_phase_execution_exception" should be passed as the 'expected' argument in the call to 'Assert.Equal(expected, actual)' in method 'ElasticSearchClient_Search_With_Scroll_Timedout_Does_Not_Throw_Exception' on type 'OrganisationSearchTests'.
Run Tests (test/OrganisationRegistry.SqlServer.IntegrationTests)
Possible null reference argument for parameter 'code' in 'MagdaLegalEntityType.MagdaLegalEntityType(string code, string description)'.
Run Tests (test/OrganisationRegistry.SqlServer.IntegrationTests): src/OrganisationRegistry.Api/Infrastructure/Magda/MagdaOrganisationResponse.cs#L73
Possible null reference argument for parameter 'description' in 'MagdaLegalEntityType.MagdaLegalEntityType(string code, string description)'.
Run Tests (test/OrganisationRegistry.SqlServer.IntegrationTests): src/OrganisationRegistry.Api/Infrastructure/Magda/MagdaOrganisationResponse.cs#L73
Possible null reference argument for parameter 'code' in 'MagdaLegalEntityType.MagdaLegalEntityType(string code, string description)'.
Run Tests (test/OrganisationRegistry.SqlServer.IntegrationTests): src/OrganisationRegistry.Api/Infrastructure/Magda/MagdaOrganisationResponse.cs#L73
Possible null reference argument for parameter 'description' in 'MagdaLegalEntityType.MagdaLegalEntityType(string code, string description)'.
Run Tests (test/OrganisationRegistry.SqlServer.IntegrationTests): test/OrganisationRegistry.SqlServer.IntegrationTests/OnProjections/Person/PersonFunctionsListViewTests.cs#L50
'OrganisationTerminated.OrganisationTerminated(Guid, string, string, DateTime, FieldsToTerminate, KboFieldsToTerminate, bool, DateTime?)' is obsolete: 'Use OrganisationTerminatedV2 instead.'
Build Vue Site
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3, actions/cache@v3, actions/setup-node@v3, actions/setup-dotnet@v3, actions/setup-python@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
Build Vue Site: src/OrganisationRegistry.Vue2/src/alerts/alerts.js#L77
Unexpected console statement
Build Vue Site: src/OrganisationRegistry.Vue2/src/api/oidc.js#L45
Unexpected console statement
Build Vue Site: src/OrganisationRegistry.Vue2/src/api/oidc.js#L46
Unexpected console statement
Build Vue Site: src/OrganisationRegistry.Vue2/src/api/oidc.js#L62
Unexpected console statement
Build Vue Site: src/OrganisationRegistry.Vue2/src/api/oidc.js#L63
Unexpected console statement
Build Vue Site: src/OrganisationRegistry.Vue2/src/api/security.js#L15
Unexpected console statement
Build Vue Site: src/OrganisationRegistry.Vue2/src/api/security.js#L34
Unexpected console statement
Notify Slack of Success
The following actions uses node12 which is deprecated and will be forced to run on node16: slackapi/[email protected]. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
Notify Slack of Success
The following actions use a deprecated Node.js version and will be forced to run on node20: slackapi/[email protected]. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
Notify Slack of Success
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Notify Slack of Success
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Notify Slack of Success
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
analyze-code
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/setup-java@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
analyze-code
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3, actions/cache@v3, actions/setup-dotnet@v3, actions/setup-java@v1. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
analyze-code: src/OrganisationRegistry.Magda/MagdaModule.cs#L54
Constructor has 8 parameters, which is greater than the 7 authorized.
analyze-code: src/OrganisationRegistry.Infrastructure/Domain/Session.cs#L80
Private record classes which are not derived in the current assembly should be marked as 'sealed'.
analyze-code: src/OrganisationRegistry.Infrastructure/EventStore/SqlServerEventReader.cs#L56
Complete the task associated to this 'TODO' comment.
analyze-code: src/OrganisationRegistry.Infrastructure/Configuration/ApiConfigurationSection.cs#L9
Make this field 'private' and encapsulate it in a 'public' property.
analyze-code: src/OrganisationRegistry.Infrastructure/Configuration/ApiConfigurationSection.cs#L9
Change the visibility of 'Name' or make it 'const' or 'readonly'.
analyze-code: src/OrganisationRegistry.Infrastructure/Configuration/AuthorizationConfigurationSection.cs#L9
Make this field 'private' and encapsulate it in a 'public' property.
analyze-code: src/OrganisationRegistry.Infrastructure/Configuration/AuthorizationConfigurationSection.cs#L9
Change the visibility of 'Name' or make it 'const' or 'readonly'.
analyze-code: src/OrganisationRegistry.Infrastructure/Configuration/CachingConfigurationSection.cs#L9
Make this field 'private' and encapsulate it in a 'public' property.