Skip to content

feat: or-2146 move osc to nuget lib #852

feat: or-2146 move osc to nuget lib

feat: or-2146 move osc to nuget lib #852

Triggered via pull request March 26, 2024 09:51
@koenmetsukoenmetsu
synchronize #1226
or-2146
Status Success
Total duration 5m 9s
Artifacts

pre-merge-tests.yml

on: pull_request
Matrix: Run Tests
Build Angular site
1m 58s
Build Angular site
Build Vue Site
3m 9s
Build Vue Site
Notify Slack of Success
3s
Notify Slack of Success
Notify Slack of Failure
0s
Notify Slack of Failure
Fit to window
Zoom out
Zoom in

Annotations

76 warnings
Build Angular site
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/cache@v3, actions/setup-node@v3, actions/setup-dotnet@v3, actions/setup-python@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Build Vue Site
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/cache@v3, actions/setup-node@v3, actions/setup-dotnet@v3, actions/setup-python@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Build Vue Site: src/OrganisationRegistry.Vue2/src/alerts/alerts.js#L77
Unexpected console statement
Build Vue Site: src/OrganisationRegistry.Vue2/src/api/oidc.js#L45
Unexpected console statement
Build Vue Site: src/OrganisationRegistry.Vue2/src/api/oidc.js#L46
Unexpected console statement
Build Vue Site: src/OrganisationRegistry.Vue2/src/api/oidc.js#L62
Unexpected console statement
Build Vue Site: src/OrganisationRegistry.Vue2/src/api/oidc.js#L63
Unexpected console statement
Build Vue Site: src/OrganisationRegistry.Vue2/src/api/security.js#L15
Unexpected console statement
Build Vue Site: src/OrganisationRegistry.Vue2/src/api/security.js#L34
Unexpected console statement
Run Tests (test/OrganisationRegistry.UnitTests)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/cache@v3, actions/setup-dotnet@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Run Tests (test/OrganisationRegistry.UnitTests)
Dereference of a possibly null reference.
Run Tests (test/OrganisationRegistry.UnitTests)
'OrganisationTerminated.OrganisationTerminated(Guid, string, string, DateTime, FieldsToTerminate, KboFieldsToTerminate, bool, DateTime?)' is obsolete: 'Use OrganisationTerminatedV2 instead.'
Run Tests (test/OrganisationRegistry.UnitTests)
Dereference of a possibly null reference.
Run Tests (test/OrganisationRegistry.UnitTests): test/OrganisationRegistry.SqlServer.IntegrationTests/OnProjections/Person/PersonFunctionsListViewTests.cs#L50
'OrganisationTerminated.OrganisationTerminated(Guid, string, string, DateTime, FieldsToTerminate, KboFieldsToTerminate, bool, DateTime?)' is obsolete: 'Use OrganisationTerminatedV2 instead.'
Run Tests (test/OrganisationRegistry.UnitTests)
'OrganisationTerminated.OrganisationTerminated(Guid, string, string, DateTime, FieldsToTerminate, KboFieldsToTerminate, bool, DateTime?)' is obsolete: 'Use OrganisationTerminatedV2 instead.'
Run Tests (test/OrganisationRegistry.UnitTests)
Dereference of a possibly null reference.
Run Tests (test/OrganisationRegistry.UnitTests)
'OrganisationTerminated.OrganisationTerminated(Guid, string, string, DateTime, FieldsToTerminate, KboFieldsToTerminate, bool, DateTime?)' is obsolete: 'Use OrganisationTerminatedV2 instead.'
Run Tests (test/OrganisationRegistry.KboMutations.UnitTests)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/cache@v3, actions/setup-dotnet@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Run Tests (test/OrganisationRegistry.KboMutations.UnitTests)
'OrganisationTerminated.OrganisationTerminated(Guid, string, string, DateTime, FieldsToTerminate, KboFieldsToTerminate, bool, DateTime?)' is obsolete: 'Use OrganisationTerminatedV2 instead.'
Run Tests (test/OrganisationRegistry.KboMutations.UnitTests)
Dereference of a possibly null reference.
Run Tests (test/OrganisationRegistry.KboMutations.UnitTests)
'OrganisationTerminated.OrganisationTerminated(Guid, string, string, DateTime, FieldsToTerminate, KboFieldsToTerminate, bool, DateTime?)' is obsolete: 'Use OrganisationTerminatedV2 instead.'
Run Tests (test/OrganisationRegistry.KboMutations.UnitTests)
Dereference of a possibly null reference.
Run Tests (test/OrganisationRegistry.KboMutations.UnitTests)
'OrganisationTerminated.OrganisationTerminated(Guid, string, string, DateTime, FieldsToTerminate, KboFieldsToTerminate, bool, DateTime?)' is obsolete: 'Use OrganisationTerminatedV2 instead.'
Run Tests (test/OrganisationRegistry.KboMutations.UnitTests)
Dereference of a possibly null reference.
Run Tests (test/OrganisationRegistry.KboMutations.UnitTests): test/OrganisationRegistry.SqlServer.IntegrationTests/OnProjections/Person/PersonFunctionsListViewTests.cs#L50
'OrganisationTerminated.OrganisationTerminated(Guid, string, string, DateTime, FieldsToTerminate, KboFieldsToTerminate, bool, DateTime?)' is obsolete: 'Use OrganisationTerminatedV2 instead.'
Run Tests (test/OrganisationRegistry.SqlServer.IntegrationTests)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/cache@v3, actions/setup-dotnet@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Run Tests (test/OrganisationRegistry.SqlServer.IntegrationTests)
Dereference of a possibly null reference.
Run Tests (test/OrganisationRegistry.SqlServer.IntegrationTests)
'OrganisationTerminated.OrganisationTerminated(Guid, string, string, DateTime, FieldsToTerminate, KboFieldsToTerminate, bool, DateTime?)' is obsolete: 'Use OrganisationTerminatedV2 instead.'
Run Tests (test/OrganisationRegistry.SqlServer.IntegrationTests)
Dereference of a possibly null reference.
Run Tests (test/OrganisationRegistry.SqlServer.IntegrationTests): test/OrganisationRegistry.SqlServer.IntegrationTests/OnProjections/Person/PersonFunctionsListViewTests.cs#L50
'OrganisationTerminated.OrganisationTerminated(Guid, string, string, DateTime, FieldsToTerminate, KboFieldsToTerminate, bool, DateTime?)' is obsolete: 'Use OrganisationTerminatedV2 instead.'
Run Tests (test/OrganisationRegistry.SqlServer.IntegrationTests)
Dereference of a possibly null reference.
Run Tests (test/OrganisationRegistry.SqlServer.IntegrationTests)
'OrganisationTerminated.OrganisationTerminated(Guid, string, string, DateTime, FieldsToTerminate, KboFieldsToTerminate, bool, DateTime?)' is obsolete: 'Use OrganisationTerminatedV2 instead.'
Run Tests (test/OrganisationRegistry.SqlServer.IntegrationTests)
Dereference of a possibly null reference.
Run Tests (test/OrganisationRegistry.SqlServer.IntegrationTests): test/OrganisationRegistry.SqlServer.IntegrationTests/OnProjections/Person/PersonFunctionsListViewTests.cs#L50
'OrganisationTerminated.OrganisationTerminated(Guid, string, string, DateTime, FieldsToTerminate, KboFieldsToTerminate, bool, DateTime?)' is obsolete: 'Use OrganisationTerminatedV2 instead.'
Run Tests (test/OrganisationRegistry.SqlServer.IntegrationTests): test/OrganisationRegistry.SqlServer.IntegrationTests/OnProjections/Person/PersonFunctionsListViewTests.cs#L50
'OrganisationTerminated.OrganisationTerminated(Guid, string, string, DateTime, FieldsToTerminate, KboFieldsToTerminate, bool, DateTime?)' is obsolete: 'Use OrganisationTerminatedV2 instead.'
analyze-code
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/cache@v3, actions/setup-dotnet@v3, actions/setup-java@v1. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
analyze-code
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/setup-java@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
analyze-code: src/OrganisationRegistry.Magda/MagdaModule.cs#L54
Constructor has 8 parameters, which is greater than the 7 authorized.
analyze-code: src/OrganisationRegistry.ElasticSearch/Bodies/BodyDocument.cs#L507
Rename class 'BodyMEP' to match pascal case naming rules, consider using 'BodyMep'.
analyze-code: src/OrganisationRegistry.ElasticSearch/Bodies/BodyDocument.cs#L531
Rename class 'BodyMEPVotingEligibility' to match pascal case naming rules, consider using 'BodyMepVotingEligibility'.
analyze-code: src/OrganisationRegistry.ElasticSearch/Bodies/BodyDocument.cs#L555
Rename class 'BodyMEPEffectivity' to match pascal case naming rules, consider using 'BodyMepEffectivity'.
analyze-code: src/OrganisationRegistry.ElasticSearch/Bodies/BodyDocument.cs#L166
Rename this method to not shadow the outer class' member with the same name.
analyze-code: src/OrganisationRegistry.ElasticSearch/Configuration/ElasticSearchConfiguration.cs#L18
Make this field 'private' and encapsulate it in a 'public' property.
analyze-code: src/OrganisationRegistry.ElasticSearch/Configuration/ElasticSearchConfiguration.cs#L18
Change the visibility of 'Section' or make it 'const' or 'readonly'.
analyze-code: src/OrganisationRegistry.ElasticSearch/Bodies/BodyDocument.cs#L244
Rename this method to not shadow the outer class' member with the same name.
analyze-code: src/OrganisationRegistry.ElasticSearch/Bodies/BodyDocument.cs#L307
Rename this method to not shadow the outer class' member with the same name.
analyze-code: src/OrganisationRegistry.ElasticSearch/Bodies/BodyDocument.cs#L352
Rename this method to not shadow the outer class' member with the same name.
Run Tests (test/OrganisationRegistry.ElasticSearch.Tests)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/cache@v3, actions/setup-dotnet@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Run Tests (test/OrganisationRegistry.ElasticSearch.Tests)
'OrganisationTerminated.OrganisationTerminated(Guid, string, string, DateTime, FieldsToTerminate, KboFieldsToTerminate, bool, DateTime?)' is obsolete: 'Use OrganisationTerminatedV2 instead.'
Run Tests (test/OrganisationRegistry.ElasticSearch.Tests)
Dereference of a possibly null reference.
Run Tests (test/OrganisationRegistry.ElasticSearch.Tests)
'OrganisationTerminated.OrganisationTerminated(Guid, string, string, DateTime, FieldsToTerminate, KboFieldsToTerminate, bool, DateTime?)' is obsolete: 'Use OrganisationTerminatedV2 instead.'
Run Tests (test/OrganisationRegistry.ElasticSearch.Tests)
'OrganisationTerminated.OrganisationTerminated(Guid, string, string, DateTime, FieldsToTerminate, KboFieldsToTerminate, bool, DateTime?)' is obsolete: 'Use OrganisationTerminatedV2 instead.'
Run Tests (test/OrganisationRegistry.ElasticSearch.Tests)
Dereference of a possibly null reference.
Run Tests (test/OrganisationRegistry.ElasticSearch.Tests)
'OrganisationTerminated.OrganisationTerminated(Guid, string, string, DateTime, FieldsToTerminate, KboFieldsToTerminate, bool, DateTime?)' is obsolete: 'Use OrganisationTerminatedV2 instead.'
Run Tests (test/OrganisationRegistry.Api.IntegrationTests)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/cache@v3, actions/setup-dotnet@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Run Tests (test/OrganisationRegistry.Api.IntegrationTests)
Dereference of a possibly null reference.
Run Tests (test/OrganisationRegistry.Api.IntegrationTests)
'OrganisationTerminated.OrganisationTerminated(Guid, string, string, DateTime, FieldsToTerminate, KboFieldsToTerminate, bool, DateTime?)' is obsolete: 'Use OrganisationTerminatedV2 instead.'
Run Tests (test/OrganisationRegistry.Api.IntegrationTests)
Dereference of a possibly null reference.
Run Tests (test/OrganisationRegistry.Api.IntegrationTests): test/OrganisationRegistry.SqlServer.IntegrationTests/OnProjections/Person/PersonFunctionsListViewTests.cs#L50
'OrganisationTerminated.OrganisationTerminated(Guid, string, string, DateTime, FieldsToTerminate, KboFieldsToTerminate, bool, DateTime?)' is obsolete: 'Use OrganisationTerminatedV2 instead.'
Run Tests (test/OrganisationRegistry.Api.IntegrationTests)
Dereference of a possibly null reference.
Run Tests (test/OrganisationRegistry.Api.IntegrationTests)
'OrganisationTerminated.OrganisationTerminated(Guid, string, string, DateTime, FieldsToTerminate, KboFieldsToTerminate, bool, DateTime?)' is obsolete: 'Use OrganisationTerminatedV2 instead.'
Run Tests (test/OrganisationRegistry.Api.IntegrationTests)
Dereference of a possibly null reference.
Run Tests (test/OrganisationRegistry.Api.IntegrationTests): test/OrganisationRegistry.SqlServer.IntegrationTests/OnProjections/Person/PersonFunctionsListViewTests.cs#L50
'OrganisationTerminated.OrganisationTerminated(Guid, string, string, DateTime, FieldsToTerminate, KboFieldsToTerminate, bool, DateTime?)' is obsolete: 'Use OrganisationTerminatedV2 instead.'
Notify Slack of Success
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: slackapi/[email protected]. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Notify Slack of Success
The following actions uses node12 which is deprecated and will be forced to run on node16: slackapi/[email protected]. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
Notify Slack of Success
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Notify Slack of Success
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Notify Slack of Success
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/