forked from cosmos/cosmos-sdk
-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add MsgExecCompat and pick other minor changes #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…der to be consumed in app
vinhphuctadang
changed the title
F/v0.47.3 inj 3
feat: add MsgExecCompat and pick other changes
Aug 22, 2023
vinhphuctadang
changed the title
feat: add MsgExecCompat and pick other changes
feat: add MsgExecCompat and pick other minor changes
Aug 22, 2023
dbrajovic
reviewed
Aug 25, 2023
dbrajovic
reviewed
Aug 25, 2023
dbrajovic
reviewed
Aug 25, 2023
albertchon
approved these changes
Aug 25, 2023
dbrajovic
approved these changes
Aug 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
https://www.notion.so/injective/EIP712-compatible-MsgExec-22c134266b434f0caa8ebd407053ac57
Changes
Create MsgExecCompat message that copies behavior from MsgExec, the only difference is to unmarshal JSON each message in msg[]
Also, we need to add
GlobalCdc
in order to parse proto JSONTest
Using client script to execute the message:
Error happens:
Using valid message format:
According to events, messages are executed correctly: