forked from crypto-org-chain/ethermint
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Firehose #7
Merged
Firehose #7
Changes from 42 commits
Commits
Show all changes
45 commits
Select commit
Hold shift + click to select a range
edd0dc4
feat: add firehose tracer
arrivets b5b917d
chore: add firehose test case in TestApplyMessageWithConfig
arrivets 8a39df1
chore: fix firehose test case
arrivets 279bd42
chore: make firehose the default tracer
arrivets f3b5e0b
chore: cleanup comment about default tracer
arrivets 2084cda
chore: move test case with firehose tracer
arrivets f19c3c0
- add firehose evm tracer hooks
Eduard-Voiculescu 94e8033
Tracer refactoring
Eduard-Voiculescu 5376e54
Adding EndBlock tracer and using the k.evmTracer instead of the trace…
Eduard-Voiculescu 65f117b
Update finalized header when begin block hook is called
Eduard-Voiculescu 7821ea6
Removing unused method and setting header values
Eduard-Voiculescu 5f5cd2c
Update tracer with custom OnCosmosBlockStart and OnCosmosBlockEnd hooks
Eduard-Voiculescu 091c32a
fix block header differences bet/ firehose tracer and eth_getBlock me…
Eduard-Voiculescu c6b80d9
removing debug log
Eduard-Voiculescu de3f90e
update statedb tracer
Eduard-Voiculescu 5558c12
adding balance change setBalance changes
Eduard-Voiculescu 929fec3
Update tracer tests for nonce changes, code changes and storage changes
Eduard-Voiculescu bcb4d47
Bumping cometbft and cosmos-sdk versions
Eduard-Voiculescu 3f8d55e
Update cometbft dependency with sf fork with changes done to PartSetH…
Eduard-Voiculescu 7867d50
Update tracer
Eduard-Voiculescu b7a2952
Fix on tx end hook call
Eduard-Voiculescu 781d9ac
Fix outdated grpc_query tests
Eduard-Voiculescu 34b4182
Adding firehose trace in the OnStorageChange call
Eduard-Voiculescu 4e2ce71
Adding test for ApplyTransactionWithTracer to check that the hooks ar…
Eduard-Voiculescu bc9cb03
- address pr comments
Eduard-Voiculescu 610f7b6
Fix issue in tracer not catching correct error in `state_transition.go`
Eduard-Voiculescu 2eb08d9
removing todo
Eduard-Voiculescu 81ed849
removing todo comment
Eduard-Voiculescu 5d807a1
Removing global registry
Eduard-Voiculescu 4a1c994
refactor: removce EVMConfigWithTracer
arrivets 4c4cf62
refactor: comment choice of tracer in prepareTrace
arrivets ba1afe5
refactor: update comment on NewEVM about RANDAO
arrivets 5d3ad48
chore: add nil check in StateDB.AddLog
arrivets f865e00
chore: remove duplicate package alias in statedb_test.go
arrivets 6a35fc9
refactor: delete unused LiveTracerRegistry
arrivets 753bad6
refactor: delete unused BlockchainTraceFactory
arrivets 7f52fb5
refactor: change name of methods that get/set tracing hooks in context
arrivets aa2d647
refactor: fix imports in x/evm/types/tracer.go
arrivets 0803635
refactor: remove unused NewLiveTracer
arrivets bd3ef46
removing the firehose switch case from the NewTracer method as we are…
Eduard-Voiculescu 7789c56
chore: add tracer in app.go
arrivets 7db3bd1
chore: refactor initializeEVM
arrivets e942116
chore: define error type for ErrConfigOverrides
arrivets 5be6f4c
chore: update TestApplyMessage
arrivets ffcfd44
chore: remove manual call to OnNonceChange after evm.Call
arrivets File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -84,3 +84,6 @@ contracts/@openzeppelin/* | |
# direnv | ||
/.envrc | ||
/.direnv | ||
|
||
# env file | ||
.env |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion
Consider extracting tracing hook setup into a helper method
The code to set up tracing hooks is duplicated in
BeginBlocker
,EndBlocker
, andInitChainer
. Extracting this into a helper method can improve code readability and maintainability.Apply this diff to extract the tracing hook setup:
Then update
BeginBlocker
:Similarly update
EndBlocker
andInitChainer
:Also applies to: 897-900, 918-923