feat: supporting WELLDONE Wallet in `wallet-ts` #193

Yoon-Suji · 2023-05-17T06:46:04Z

Description

Hello, We are WELLDONE Studio team from DSRV. We want to add supporting WELLDONE Wallet in wallet-ts.
WELLDONE extension wallet is multi-chain wallet that support Injective protocol. You can find more information about WELLDONE Wallet here.

Summary by CodeRabbit

New Features
- Introduced support for the Welldone wallet, enabling users to interact with Cosmos-based chains directly from the app.
- Added new functionalities for the Welldone wallet, including transaction signing, address retrieval, and wallet enabling.

packages/wallet-ts/src/strategies/cosmos-wallet-strategy/strategies/Welldone.ts

packages/wallet-ts/src/strategies/wallet-strategy/strategies/Welldone.ts

packages/wallet-ts/src/utils/wallets/welldone/WelldoneWallet.ts

Yoon-Suji · 2023-05-18T08:42:05Z

Hi, @bangjelkoski
Thank you for comment and sorry for the code format issue. I fixed it. Would you check that again?

bangjelkoski · 2023-05-18T08:43:25Z

packages/wallet-ts/src/utils/wallets/welldone/WelldoneWallet.ts

+      return {
+        signed: signDoc,
+        signature: {
+          pub_key: encodeSecp256k1Pubkey(


Have you tested this on Injective tho? Because we are using another pubkey encoding/signing scheme and I think this will not work for us.

@bangjelkoski
When I tested it with simple counter example it worked well. But I agree that it's wrong. I'll fix it.

okay, thanks, ping me when its done!

injective-ts/packages/sdk-ts/src/core/modules/tx/utils/tx.ts

Lines 14 to 46 in 06e2f85

export const getPublicKey = ({

chainId,

key,

}: {

chainId: string

key: string | GoogleProtobufAny.Any

}) => {

if (typeof key !== 'string') {

return key

}

let proto

let path

let baseProto

if (chainId.startsWith('injective')) {

proto = CosmosCryptoSecp256k1Keys.PubKey.create()

baseProto = CosmosCryptoSecp256k1Keys.PubKey

path = '/injective.crypto.v1beta1.ethsecp256k1.PubKey'

} else if (chainId.startsWith('evmos')) {

proto = CosmosCryptoSecp256k1Keys.PubKey.create()

baseProto = CosmosCryptoSecp256k1Keys.PubKey

path = '/ethermint.crypto.v1.ethsecp256k1.PubKey'

} else {

proto = CosmosCryptoSecp256k1Keys.PubKey.create()

baseProto = CosmosCryptoSecp256k1Keys.PubKey

path = '/cosmos.crypto.secp256k1.PubKey'

}

proto.key = Buffer.from(key, 'base64')

return createAny(baseProto.encode(proto).finish(), path)

}

you can use this function

@bangjelkoski Thank you! I modified the code using getPublicKey function. Please check it.

Please check it. @bangjelkoski

I did but there are some pending changes requested below that are still open and not implemented

bangjelkoski · 2023-05-29T17:04:12Z

@daoauth @Yoon-Suji can we update the PR so we can finally finish it?

Yoon-Suji · 2023-05-30T07:10:50Z

@bangjelkoski Yes, I already updated my code so we can finish :)

bangjelkoski · 2023-05-19T10:59:19Z

packages/wallet-ts/src/utils/wallets/welldone/WelldoneWallet.ts

+
+    authInfo.signerInfos.forEach((signerInfo) => {
+      if (signerInfo.publicKey) {
+        signerInfo.publicKey.typeUrl = '/cosmos.crypto.secp256k1.PubKey'


This should be related to the chainId, not hardcoded for Cosmos

@bangjelkoski
WELLDONE Wallet use ‘secp245k1’ instead of ‘ethsecp256k1’ for unity with other cosmos chains. Therefore the injective account provided in the wallet is also made of ‘secp255k1’.

However, in the case of using MsgBroadCaster, the method createSignerinfo() is used in the process of making txRaw, and inside that method, it uses getPublicKey() that put publicKey’s type to '/injective.crypto.v1beta1.ethsecp256k1.PubKey' when the chainId starts with injective.
https://github.com/InjectiveLabs/injective-ts/blob/master/packages/sdk-ts/src/core/modules/tx/utils/tx.ts#L14

Therefore, in order to prepare for these exceptions, we added a part that changes the pubkey of authinfo to ‘secp256k1’ if you want to sign using WELLDONE Wallet. This is because we can use ‘stargate’ with the same environment as other cosmos chains.

now change to '/injective.crypto.v1beta1.ethsecp256k1.PubKey'

bangjelkoski · 2023-05-19T11:01:17Z

packages/wallet-ts/src/utils/wallets/welldone/WelldoneWallet.ts

+        method: 'dapp:signTransaction',
+        params: [`0x${Buffer.from(signBytes).toString('hex')}`],
+      })
+      const pubKey = getPublicKey({


Blank space above

bangjelkoski · 2023-05-19T11:01:29Z

packages/wallet-ts/src/utils/wallets/welldone/WelldoneWallet.ts

+      return {
+        signed: signDoc,
+        signature: {
+          pub_key: pubKey as any,


Why do you cast it as any here?

Because getPublicKey() return type is Any. So it throws an error that "Property 'type' is missing in type 'Any' but required in type 'Pubkey'."

bangjelkoski · 2023-05-24T11:30:58Z

packages/wallet-ts/src/utils/wallets/welldone/WelldoneWallet.ts

+      return {
+        signed: signDoc,
+        signature: {
+          pub_key: encodeSecp256k1Pubkey(


I did but there are some pending changes requested below that are still open and not implemented

bangjelkoski · 2023-05-31T10:43:49Z

@bangjelkoski Yes, I already updated my code so we can finish :)

How about these changes: #193 (comment)

chanage to /injective.crypto.v1beta1.ethsecp256k1.PubKey

daoauth · 2024-01-09T02:15:44Z

@bangjelkoski Yes, I already updated my code so we can finish :)

How about these changes: #193 (comment)

i change to /injective.crypto.v1beta1.ethsecp256k1.PubKey
thanks

coderabbitai · 2024-03-07T01:37:18Z

Walkthrough

The recent update introduces the Welldone wallet strategy for Cosmos-based chains, expanding the wallet's capabilities within the project. It includes a new wallet strategy class, updates to enums and utility functions, and the introduction of a WelldoneWallet class for detailed interactions with the Welldone wallet. This enhancement broadens support for Cosmos transactions and wallet management, ensuring better integration and functionality for users of the Welldone wallet.

Changes

File Path	Change Summary
`.../strategies/wallet-strategy/strategies/Welldone.ts`	Introduced `Welldone` wallet strategy class with various wallet interaction methods.
`.../types/enums.ts`	Added `Welldone` enum value.
`.../utils/wallets/cosmos/utils.ts`	Updated to support `Welldone` wallet checks.
`.../utils/wallets/index.ts`	Added export for `welldone` module.
`.../utils/wallets/welldone/WelldoneWallet.ts` `.../utils/wallets/welldone/index.ts` `.../utils/wallets/welldone/welldone.d.ts`	Added `WelldoneWallet` class and related exports and interfaces for interacting with the Welldone wallet.

🐰✨
In the realm of code, where wallets intertwine,
A new strategy emerges, Welldone, so fine.
With Cosmos in heart, it strides with grace,
Across the blockchain, it finds its place.
So here's to the builders, with vision so bright,
May your wallets connect, in the soft moonlight.
🌕💼✨

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>.
- Generate unit-tests for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit tests for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai generate interesting stats about this repository and render them as a table.
- @coderabbitai show all the console.log statements in this repository.
- @coderabbitai read src/utils.ts and generate unit tests.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
The JSON schema for the configuration file is available here.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

coderabbitai

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits

Files that changed from the base of the PR and between c7c6d91 and 0cd7408.

Files selected for processing (9)

packages/wallet-ts/src/strategies/cosmos-wallet-strategy/strategies/Welldone.ts (1 hunks)
packages/wallet-ts/src/strategies/wallet-strategy/WalletStrategy.ts (2 hunks)
packages/wallet-ts/src/strategies/wallet-strategy/strategies/Welldone.ts (1 hunks)
packages/wallet-ts/src/types/enums.ts (1 hunks)
packages/wallet-ts/src/utils/wallets/cosmos/utils.ts (4 hunks)
packages/wallet-ts/src/utils/wallets/index.ts (1 hunks)
packages/wallet-ts/src/utils/wallets/welldone/WelldoneWallet.ts (1 hunks)
packages/wallet-ts/src/utils/wallets/welldone/index.ts (1 hunks)
packages/wallet-ts/src/utils/wallets/welldone/welldone.d.ts (1 hunks)

Files skipped from review due to trivial changes (1)

packages/wallet-ts/src/utils/wallets/welldone/index.ts

Additional comments: 11

packages/wallet-ts/src/utils/wallets/index.ts (1)

6-6: The addition of the welldone module export is correctly implemented and aligns with the PR's objective to support the WELLDONE Wallet.

packages/wallet-ts/src/utils/wallets/welldone/welldone.d.ts (1)

1-17: The interface definitions for RequestParams and WalletProvider, along with the extension of the global Window interface, are correctly implemented and align with the PR's objectives for integrating WELLDONE Wallet support.

packages/wallet-ts/src/types/enums.ts (1)

19-19: The addition of the Welldone value to the Wallet enum is correctly implemented and necessary for the library to recognize and interact with the WELLDONE Wallet.

packages/wallet-ts/src/utils/wallets/cosmos/utils.ts (3)

5-5: Importing WalletProvider from ../welldone/welldone is necessary for the changes related to the WELLDONE Wallet support.

30-30: Expanding the isCosmosBrowserWallet function to include Wallet.Welldone is correctly implemented and aligns with the PR's objectives.

52-59: > 📝 NOTE

This review was outside the diff hunks and was mapped to the diff hunk with the greatest overlap. Original lines [43-56]

Updating the isCosmosWalletInstalled function to check for the presence of dapp in the wallet provider object for Wallet.Welldone is correctly implemented and necessary for the integration.

packages/wallet-ts/src/strategies/cosmos-wallet-strategy/strategies/Welldone.ts (1)

1-133: The Welldone class implementing ConcreteCosmosWalletStrategy is correctly implemented, including methods for wallet interaction that align with the PR's objectives. The explicit handling of unsupported operations and consistent error handling are notable.

packages/wallet-ts/src/utils/wallets/welldone/WelldoneWallet.ts (1)

1-209: The WelldoneWallet class is correctly implemented, including methods for wallet interaction that align with the PR's objectives. The explicit handling of unsupported operations, consistent error handling, and the method to check for supported networks are notable.

packages/wallet-ts/src/strategies/wallet-strategy/strategies/Welldone.ts (1)

1-209: The Welldone class implementing ConcreteWalletStrategy is correctly implemented, including methods for wallet interaction that align with the PR's objectives. The explicit handling of unsupported operations and consistent error handling are notable.

packages/wallet-ts/src/strategies/wallet-strategy/WalletStrategy.ts (2)

25-25: The import statement for the Welldone strategy is correctly placed and follows the existing pattern of importing wallet strategies. This ensures that the Welldone class is available for use within the WalletStrategy class.

106-107: The integration of the Welldone strategy within the createStrategy function is correctly implemented. It follows the established pattern for integrating new wallet strategies, ensuring consistency and maintainability. The use of the spread operator to pass arguments is appropriate and aligns with the implementation of other strategies.

Yoon-Suji added 4 commits April 26, 2023 18:32

feat: add WELLDONE wallet to wallet-ts

860b3f3

fix: broadcastTx, signTx in WelldoneWallet

2002ea8

feat: add WELLLDONE wallet to CosmosWalletStrategy

33336d2

fix: modify public key type for welldone wallet

a8fe17c

bangjelkoski requested changes May 17, 2023

View reviewed changes

fix: linting

e6585e3

bangjelkoski reviewed May 18, 2023

View reviewed changes

fix: signTransaction return pub_key in WELLDONE Wallet

9053217

Yoon-Suji force-pushed the welldone branch from f465b8e to 9053217 Compare May 19, 2023 10:53

bangjelkoski approved these changes May 31, 2023

View reviewed changes

daoauth added 4 commits January 5, 2024 11:25

Merge branch 'dev' into welldone

669278d

Merge branch 'InjectiveLabs:dev' into welldone

1f8dbee

update welldone wallet

49fee04

Update WelldoneWallet.ts

d3dcaa2

chanage to /injective.crypto.v1beta1.ethsecp256k1.PubKey

daoauth added 2 commits January 9, 2024 11:17

remove change pubKey type

34d12b4

Merge branch 'dev' into welldone

0cd7408

coderabbitai bot reviewed Mar 7, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: supporting WELLDONE Wallet in `wallet-ts` #193

feat: supporting WELLDONE Wallet in `wallet-ts` #193

Yoon-Suji commented May 17, 2023 •

edited by coderabbitai bot

Loading

Yoon-Suji commented May 18, 2023

bangjelkoski May 18, 2023

Yoon-Suji May 18, 2023

bangjelkoski May 19, 2023

bangjelkoski May 19, 2023

Yoon-Suji May 19, 2023

daoauth May 24, 2023

bangjelkoski May 24, 2023

bangjelkoski commented May 29, 2023

Yoon-Suji commented May 30, 2023

bangjelkoski May 19, 2023

Yoon-Suji Jun 1, 2023

daoauth Jan 9, 2024

bangjelkoski May 19, 2023

bangjelkoski May 19, 2023

Yoon-Suji May 31, 2023

bangjelkoski May 24, 2023

bangjelkoski commented May 31, 2023

daoauth commented Jan 9, 2024

coderabbitai bot commented Mar 7, 2024 •

edited

Loading

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (`.coderabbit.yaml`)

CodeRabbit Discord Community

coderabbitai bot left a comment

	export const getPublicKey = ({
	chainId,
	key,
	}: {
	chainId: string
	key: string \| GoogleProtobufAny.Any
	}) => {
	if (typeof key !== 'string') {
	return key
	}

	let proto
	let path
	let baseProto

	if (chainId.startsWith('injective')) {
	proto = CosmosCryptoSecp256k1Keys.PubKey.create()
	baseProto = CosmosCryptoSecp256k1Keys.PubKey
	path = '/injective.crypto.v1beta1.ethsecp256k1.PubKey'
	} else if (chainId.startsWith('evmos')) {
	proto = CosmosCryptoSecp256k1Keys.PubKey.create()
	baseProto = CosmosCryptoSecp256k1Keys.PubKey
	path = '/ethermint.crypto.v1.ethsecp256k1.PubKey'
	} else {
	proto = CosmosCryptoSecp256k1Keys.PubKey.create()
	baseProto = CosmosCryptoSecp256k1Keys.PubKey
	path = '/cosmos.crypto.secp256k1.PubKey'
	}

	proto.key = Buffer.from(key, 'base64')

	return createAny(baseProto.encode(proto).finish(), path)
	}

feat: supporting WELLDONE Wallet in wallet-ts #193

Are you sure you want to change the base?

feat: supporting WELLDONE Wallet in wallet-ts #193

Conversation

Yoon-Suji commented May 17, 2023 • edited by coderabbitai bot Loading

Description

Summary by CodeRabbit

Yoon-Suji commented May 18, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

bangjelkoski commented May 29, 2023

Yoon-Suji commented May 30, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

bangjelkoski commented May 31, 2023

daoauth commented Jan 9, 2024

coderabbitai bot commented Mar 7, 2024 • edited Loading

Walkthrough

Changes

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (.coderabbit.yaml)

CodeRabbit Discord Community

coderabbitai bot left a comment

Choose a reason for hiding this comment

feat: supporting WELLDONE Wallet in `wallet-ts` #193

feat: supporting WELLDONE Wallet in `wallet-ts` #193

Yoon-Suji commented May 17, 2023 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Mar 7, 2024 •

edited

Loading

CodeRabbit Configration File (`.coderabbit.yaml`)