Fix Eip712TypedDataV2 for date-type #469
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, the getEip712TypedDataV2 method doesn't work correctly for a Date. As a consequence, a transaction that has Messages with Date type fields cannot be correctly signed. For example for a message of type MsgGrant method generate:
Blockchain expected:
I'm not sure if this patch is good and won't break other Messages that use the Date type. It may also be better to make this modification on the blockchain
Summary by CodeRabbit