Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Eip712TypedDataV2 for date-type #469

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

Grinion
Copy link
Contributor

@Grinion Grinion commented Apr 30, 2024

Hi, the getEip712TypedDataV2 method doesn't work correctly for a Date. As a consequence, a transaction that has Messages with Date type fields cannot be correctly signed. For example for a message of type MsgGrant method generate:

Screenshot 2024-04-30 at 15 39 52

Blockchain expected:

Screenshot 2024-04-30 at 15 41 24

I'm not sure if this patch is good and won't break other Messages that use the Date type. It may also be better to make this modification on the blockchain

Summary by CodeRabbit

  • New Features
    • Enhanced handling of Date objects in transaction data processing to improve accuracy and reliability.

Copy link

coderabbitai bot commented Apr 30, 2024

Walkthrough

A new function, Eip712TypedDataV2Replacer, has been introduced to enhance the handling of Date objects in JSON stringification within the EIP712 module. This function is now utilized in the getEip712TypedDataV2 to ensure proper formatting of Date objects during the creation of EIP transaction contexts.

Changes

File Path Change Summary
.../eip712/eip712.ts Added Eip712TypedDataV2Replacer for JSON stringification of Date objects.

🐰✨🌟
In the code's woven maze, a twist, a turn,
A function new, for Dates it yearns.
Through JSON strings, it hops and skips,
Crafting contexts with clever quips.
Cheers to changes, small but bright,
In digital realms, a coder's delight!
🌟✨🐰


Recent Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits Files that changed from the base of the PR and between b8e13e7 and 2638e7c.
Files selected for processing (1)
  • packages/sdk-ts/src/core/modules/tx/eip712/eip712.ts (2 hunks)
Files not reviewed due to errors (1)
  • packages/sdk-ts/src/core/modules/tx/eip712/eip712.ts (no review received)

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@bangjelkoski
Copy link
Collaborator

Is this PR still needed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants