Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/sync dec with master v1 51 1 #233

Merged
merged 13 commits into from
Aug 7, 2024
Merged

Conversation

aarmoa
Copy link
Collaborator

@aarmoa aarmoa commented Aug 7, 2024

  • PR to sync dev branch with the latest release in master (v1.51.1)

Summary by CodeRabbit

  • New Features

    • Introduced a MinNotional parameter across multiple trading assets, allowing for minimum transaction size requirements.
    • Added new command-line applications for managing trading positions, updating market parameters, and authorizing stake grants on the blockchain.
  • Documentation

    • Updated installation and example running instructions in the README for clarity and accuracy.
  • Bug Fixes

    • Improved market configuration by restructuring how trading parameters are defined and accessed in configuration files.

Copy link

coderabbitai bot commented Aug 7, 2024

Caution

Review failed

The pull request is closed.

Walkthrough

The recent changes enhance the trading system's configurability and functionality, introducing a MinNotional value for market definitions and modifying various components to support this feature. The updates also include improved command-line tools for interacting with the blockchain, ensuring better management of trading parameters and stakeholder actions. Workflow adjustments in the testing and configuration files further support these enhancements, contributing to a more robust trading environment.

Changes

File Change Summary
.github/workflows/run-tests.yml Updated Codecov Action version from v3 to v4.
README.md Revised installation and example running instructions, reflecting a restructured example directory.
client/chain/markets_assistant.go Added MinNotional field to market assistants, enhancing market configurability.
client/chain/markets_assistant_test_support.go Introduced MinNotional to market info creation functions.
client/core/market.go Added MinNotional to SpotMarket and DerivativeMarket, included methods for notional value conversions.
client/core/market_test.go Added tests for notional value conversions; initialized MinNotional in market structures.
client/metadata/assets/*.ini Added min_notional to various asset definitions; updated peggy_denom paths and token decimals.
examples/chain/exchange/*.go Multiple command-line tools introduced for trading actions, incorporating MinNotional in relevant messages.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant CLI
    participant Blockchain
    participant MarketAssistant

    User->>CLI: Launch trading action
    CLI->>MarketAssistant: Get market parameters
    MarketAssistant->>CLI: Return market info
    CLI->>Blockchain: Send transaction with parameters
    Blockchain-->>CLI: Confirm transaction
    CLI-->>User: Display transaction status
Loading

🐰 In a world of trades and hops,
A new value we now adopt!
With notional limits, we take our chance,
In a market dance, let’s prance!
So gather round, both big and small,
For trading joy will soon enthrall!
🌟✨


Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@aarmoa aarmoa merged commit 69dc9c1 into dev Aug 7, 2024
6 checks passed
@aarmoa aarmoa deleted the feat/sync_dec_with_master_v1_51_1 branch August 7, 2024 02:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants