-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove duplicate error handling in authz_vote.go #241
Conversation
This PR removes a redundant error handling block in the `authz_vote.go` file to improve code clarity and reduce unnecessary code duplication. Signed-off-by: Hwangjae Lee <[email protected]>
WalkthroughThe pull request introduces a modification to the error handling logic in the Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
@aarmoa Hey, I’ve rebased to the dev branch and created the PR. Could you review it? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #241 +/- ##
==========================================
+ Coverage 15.77% 21.85% +6.08%
==========================================
Files 25 29 +4
Lines 4722 4378 -344
==========================================
+ Hits 745 957 +212
+ Misses 3946 3363 -583
- Partials 31 58 +27 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor change that does not have a big impact. We can merge this in my opinion.
This PR removes a redundant error handling block in the
authz_vote.go
file to improve code clarity and reduce unnecessary code duplication.hanges:
if err != nil { panic(err) }
block after initializing tmClient as it was duplicated and redundant.Summary by CodeRabbit
Bug Fixes
Chores