Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix/sync_network_endpoints_with_go_sdk #250

Merged
merged 1 commit into from
Sep 20, 2023

Conversation

aarmoa
Copy link
Collaborator

@aarmoa aarmoa commented Sep 20, 2023

  • Added the port number in the endpoints where it was missing, to synchronize networks configuration with Go SDK

@aarmoa aarmoa changed the title fix/sync_network_endpoints_with_go_sdk' fix/sync_network_endpoints_with_go_sdk Sep 20, 2023
@codecov
Copy link

codecov bot commented Sep 20, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (9ceb008) 56.33% compared to head (bbd7b3d) 56.33%.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev     #250   +/-   ##
=======================================
  Coverage   56.33%   56.33%           
=======================================
  Files          17       17           
  Lines        2036     2036           
  Branches      239      239           
=======================================
  Hits         1147     1147           
  Misses        853      853           
  Partials       36       36           
Files Changed Coverage Δ
pyinjective/core/network.py 38.97% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aarmoa aarmoa merged commit 7078a76 into dev Sep 20, 2023
12 checks passed
@aarmoa aarmoa deleted the fix/sync_network_endpoints_with_go_sdk branch September 20, 2023 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant