-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release v1.6.0 #337
Release v1.6.0 #337
Conversation
…njectiveLabs/sdk-python into feat/tendermint_module_queries
…ries Feat/tendermint module queries
…assistant and replaced it with a general ExpiringCookieAssistant. Updated all unit tests.
feat/reduce_calls_for_cookies
… message. Added unit tests and script examples
feat/add_ibc_transfer_support
…le_queries feat/ibc_core_channel_module_queries
…https://github.com/InjectiveLabs/sdk-python into feat/network_refactoring_from_master_to_dev
…rom_master_to_dev Feat/network refactoring from master to dev
…e scripts for all queries and unit tests
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
…ries feat/ibc_client_module_queries
…e. Included example scripts and unit tests
…ed message in JSON representation
…te version for v1.13 upgrade
…n for chain upgrade v1.13
…te version for v1.13 upgrade
…ive-indexer versions (candidate for chain upgrade to v1.13)
…ive-core and injective-indexer v1.13 candidate versions
…o feat/update_dependencies_chain_v1_13
…ive-core and injective-indexer v1.13 candidate versions
…n Unicode standard characters
…n Unicode standard characters
…st and examples. Updated all markets and tokens INI files
…hain_v1_13 feat/update_dependencies_chain_v1_13
WalkthroughThe recent changes significantly enhance the Changes
Poem
TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
…tokens list. Regenerated the denoms INI files
…ng_issue fix/solve_token_list_parsing_issue
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 4
Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files selected for processing (2)
- pyinjective/async_client.py (31 hunks)
- pyinjective/denoms_devnet.ini (1 hunks)
Additional comments not posted (88)
pyinjective/denoms_devnet.ini (81)
310-312
: LGTM!The asset entry for
[1INCH]
is correct and consistent with the new format.
314-316
: LGTM!The asset entry for
[AAVE]
is correct and consistent with the new format.
318-320
: LGTM!The asset entry for
[ALPHA]
is correct and consistent with the new format.
322-324
: LGTM!The asset entry for
[ANDR]
is correct and consistent with the new format.
326-328
: LGTM!The asset entry for
[APE]
is correct and consistent with the new format.
330-332
: LGTM!The asset entry for
[APP]
is correct and consistent with the new format.
334-336
: LGTM!The asset entry for
[ARB]
is correct and consistent with the new format.
338-340
: LGTM!The asset entry for
[ARBlegacy]
is correct and consistent with the new format.
342-344
: LGTM!The asset entry for
[ASG]
is correct and consistent with the new format.
346-348
: LGTM!The asset entry for
[ASTR]
is correct and consistent with the new format.
350-352
: LGTM!The asset entry for
[ASTRO]
is correct and consistent with the new format.
354-356
: LGTM!The asset entry for
[ATOM]
is correct and consistent with the new format.
358-360
: LGTM!The asset entry for
[AUTISM]
is correct and consistent with the new format.
362-364
: LGTM!The asset entry for
[AVAX]
is correct and consistent with the new format.
366-368
: LGTM!The asset entry for
[AXL]
is correct and consistent with the new format.
370-372
: LGTM!The asset entry for
[AXS]
is correct and consistent with the new format.
374-376
: LGTM!The asset entry for
[Alpha Coin]
is correct and consistent with the new format.
378-380
: LGTM!The asset entry for
[Ape Coin]
is correct and consistent with the new format.
382-384
: LGTM!The asset entry for
[Arbitrum]
is correct and consistent with the new format.
386-388
: LGTM!The asset entry for
[Axelar]
is correct and consistent with the new format.
390-392
: LGTM!The asset entry for
[BAMBOO]
is correct and consistent with the new format.
394-396
: LGTM!The asset entry for
[BAND]
is correct and consistent with the new format.
398-400
: LGTM!The asset entry for
[BAT]
is correct and consistent with the new format.
402-404
: LGTM!The asset entry for
[BAYC]
is correct and consistent with the new format.
406-408
: LGTM!The asset entry for
[BEAST]
is correct and consistent with the new format.
410-412
: LGTM!The asset entry for
[BINJ]
is correct and consistent with the new format.
414-416
: LGTM!The asset entry for
[BITS]
is correct and consistent with the new format.
418-420
: LGTM!The asset entry for
[BLACK]
is correct and consistent with the new format.
422-424
: LGTM!The asset entry for
[BMOS]
is correct and consistent with the new format.
426-428
: LGTM!The asset entry for
[BNB]
is correct and consistent with the new format.
430-432
: LGTM!The asset entry for
[BODEN]
is correct and consistent with the new format.
434-436
: LGTM!The asset entry for
[BONJO]
is correct and consistent with the new format.
438-440
: LGTM!The asset entry for
[BONK]
is correct and consistent with the new format.
442-444
: LGTM!The asset entry for
[BONUS]
is correct and consistent with the new format.
446-448
: LGTM!The asset entry for
[BRETT]
is correct and consistent with the new format.
450-452
: LGTM!The asset entry for
[BRZ]
is correct and consistent with the new format.
454-456
: LGTM!The asset entry for
[BSKT]
is correct and consistent with the new format.
458-460
: LGTM!The asset entry for
[BTC]
is correct and consistent with the new format.
462-464
: LGTM!The asset entry for
[BULLS]
is correct and consistent with the new format.
466-468
: LGTM!The asset entry for
[BUSD]
is correct and consistent with the new format.
474-476
: LGTM!The asset entry for
[Basket]
is correct and consistent with the new format.
478-480
: LGTM!The asset entry for
[Bird INJ]
is correct and consistent with the new format.
482-484
: LGTM!The asset entry for
[BitSong]
is correct and consistent with the new format.
486-488
: LGTM!The asset entry for
[Bonjo]
is correct and consistent with the new format.
490-492
: LGTM!The asset entry for
[Brazilian Digital Token]
is correct and consistent with the new format.
494-496
: LGTM!The asset entry for
[CAD]
is correct and consistent with the new format.
498-500
: LGTM!The asset entry for
[CANTO]
is correct and consistent with the new format.
502-504
: LGTM!The asset entry for
[CEL]
is correct and consistent with the new format.
506-508
: LGTM!The asset entry for
[CELL]
is correct and consistent with the new format.
510-512
: LGTM!The asset entry for
[CHZ]
is correct and consistent with the new format.
514-516
: LGTM!The asset entry for
[CHZlegacy]
is correct and consistent with the new format.
518-520
: LGTM!The asset entry for
[CLON]
is correct and consistent with the new format.
522-524
: LGTM!The asset entry for
[COCK]
is correct and consistent with the new format.
526-528
: LGTM!The asset entry for
[COKE]
is correct and consistent with the new format.
530-532
: LGTM!The asset entry for
[COMP]
is correct and consistent with the new format.
534-536
: LGTM!The asset entry for
[CRE]
is correct and consistent with the new format.
538-540
: LGTM!The asset entry for
[CVR]
is correct and consistent with the new format.
542-544
: LGTM!The asset entry for
[Chiliz (legacy)]
is correct and consistent with the new format.
546-548
: LGTM!The asset entry for
[Cosmos]
is correct and consistent with the new format.
550-552
: LGTM!The asset entry for
[DAI]
is correct and consistent with the new format.
554-556
: LGTM!The asset entry for
[DDL]
is correct and consistent with the new format.
558-560
: LGTM!The asset entry for
[DEFI5]
is correct and consistent with the new format.
562-564
: LGTM!The asset entry for
[DEMO]
is correct and consistent with the new format.
566-568
: LGTM!The asset entry for
[DGNZ]
is correct and consistent with the new format.
570-572
: LGTM!The asset entry for
[DOGE]
is correct and consistent with the new format.
574-576
: LGTM!The asset entry for
[DOJ]
is correct and consistent with the new format.
578-580
: LGTM!The asset entry for
[DOJO]
is correct and consistent with the new format.
582-584
: LGTM!The asset entry for
[DOT]
is correct and consistent with the new format.
586-588
: LGTM!The asset entry for
[DREAM]
is correct and consistent with the new format.
590-592
: LGTM!The asset entry for
[DROGO]
is correct and consistent with the new format.
594-596
: LGTM!The asset entry for
[DUDE]
is correct and consistent with the new format.
598-600
: LGTM!The asset entry for
[Dojo Token]
is correct and consistent with the new format.
602-604
: LGTM!The asset entry for
[ELON]
is correct and consistent with the new format.
606-608
: LGTM!The asset entry for
[ENA]
is correct and consistent with the new format.
610-612
: LGTM!The asset entry for
[ENJ]
is correct and consistent with the new format.
614-616
: LGTM!The asset entry for
[ERIC]
is correct and consistent with the new format.
618-620
: LGTM!The asset entry for
[ETH]
is correct and consistent with the new format.
622-624
: LGTM!The asset entry for
[ETHBTCTrend]
is correct and consistent with the new format.
626-628
: LGTM!The asset entry for
[EUR]
is correct and consistent with the new format.
630-632
: LGTM!The asset entry for
[EVAI]
is correct and consistent with the new format.
634-636
: LGTM!The asset entry for
[EVIINDEX]
is correct andpyinjective/async_client.py (7)
5-5
: New imports approved.The new imports for IBC and Tendermint functionalities are necessary and correctly used in the code.
Also applies to: 16-16, 39-42, 45-47, 58-58, 80-82
168-296
: Constructor changes approved.The constructor now includes new API classes for IBC and Tendermint functionalities, correctly instantiated and used.
Line range hint
355-474
: Deprecation and new methods approved.The deprecated methods are correctly marked, and the new methods are properly implemented.
Also applies to: 1206-1215
3036-3134
: New IBC methods approved.The new methods for IBC functionalities are correctly implemented and follow best practices.
Also applies to: 3138-3210
1200-1232
: New Tendermint methods approved.The new methods for Tendermint functionalities are correctly implemented and follow best practices.
1198-1199
: Changes in token methods approved.The changes in token methods, including new helper methods and refactoring, are correctly implemented and follow best practices.
Also applies to: 3293-3449
Line range hint
3449-3455
: Changes in timeout methods approved.The changes in timeout methods, including new methods for handling timeout height synchronization, are correctly implemented and follow best practices.
[$Babykira] | ||
peggy_denom = factory/inj13vau2mgx6mg7ams9nngjhyng58tl9zyw0n8s93/$babykira | ||
decimals = 6 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ensure consistency in asset identifiers.
The asset identifier [$Babykira]
should be consistent with other identifiers, which typically do not include the $
symbol.
- [$Babykira]
+ [Babykira]
Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
[$Babykira] | |
peggy_denom = factory/inj13vau2mgx6mg7ams9nngjhyng58tl9zyw0n8s93/$babykira | |
decimals = 6 | |
[Babykira] | |
peggy_denom = factory/inj13vau2mgx6mg7ams9nngjhyng58tl9zyw0n8s93/$babykira | |
decimals = 6 |
[$ALIEN] | ||
peggy_denom = factory/inj1mly2ykhf6f9tdj58pvndjf4q8dzdl4myjqm9t6/$alien | ||
decimals = 6 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ensure consistency in asset identifiers.
The asset identifier [$ALIEN]
should be consistent with other identifiers, which typically do not include the $
symbol.
- [$ALIEN]
+ [ALIEN]
Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
[$ALIEN] | |
peggy_denom = factory/inj1mly2ykhf6f9tdj58pvndjf4q8dzdl4myjqm9t6/$alien | |
decimals = 6 | |
[ALIEN] | |
peggy_denom = factory/inj1mly2ykhf6f9tdj58pvndjf4q8dzdl4myjqm9t6/$alien | |
decimals = 6 |
[$AOI] | ||
peggy_denom = factory/inj169ed97mcnf8ay6rgvskn95n6tyt46uwvy5qgs0/$aoi | ||
decimals = 6 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ensure consistency in asset identifiers.
The asset identifier [$AOI]
should be consistent with other identifiers, which typically do not include the $
symbol.
- [$AOI]
+ [AOI]
Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
[$AOI] | |
peggy_denom = factory/inj169ed97mcnf8ay6rgvskn95n6tyt46uwvy5qgs0/$aoi | |
decimals = 6 | |
[AOI] | |
peggy_denom = factory/inj169ed97mcnf8ay6rgvskn95n6tyt46uwvy5qgs0/$aoi | |
decimals = 6 |
[Babykira] | ||
peggy_denom = factory/inj15jeczm4mqwtc9lk4c0cyynndud32mqd4m9xnmu/$babykira | ||
decimals = 6 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ensure consistency in asset identifiers.
The asset identifier [Babykira]
is duplicated and should be checked for consistency.
- [Babykira]
+ [Babykira] (remove duplicate)
Committable suggestion was skipped due to low confidence.
… using the order's identifiers
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #337 +/- ##
==========================================
+ Coverage 76.25% 77.88% +1.62%
==========================================
Files 50 57 +7
Lines 4111 4580 +469
Branches 351 333 -18
==========================================
+ Hits 3135 3567 +432
- Misses 871 920 +49
+ Partials 105 93 -12 ☔ View full report in Codecov by Sentry. |
…on_without_order_mask Feat/add order data creation without order mask
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files selected for processing (1)
- pyinjective/composer.py (21 hunks)
Files skipped from review as they are similar to previous changes (1)
- pyinjective/composer.py
Summary by CodeRabbit
New Features
denoms_devnet.ini
, streamlining asset representation by focusing on essential attributes.Bug Fixes
Chores