Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix/feat: add fix for multi-hop buys and contract migration system #15

Merged
merged 7 commits into from
Feb 25, 2024

Conversation

gorgos
Copy link
Member

@gorgos gorgos commented Feb 24, 2024

  • Added Changelog and rust-toolchain file
  • Added contract migration templates and migrate function
  • Correctly round to min_quantity_tick_size in intermediate steps for multi-hop buys

Summary by CodeRabbit

  • New Features
    • Introduced a Changelog file for tracking notable project changes.
    • Added contract migration templates and a migrate function for seamless updates.
    • Implemented a validation step in contract administration for enhanced data integrity.
    • Updated logic for rounding to min_quantity_tick_size in multi-hop buys for market compliance.
  • Bug Fixes
    • Corrected the spelling in an error message for unrecognized reply IDs.
  • Documentation
    • Updated error documentation to include a new variant for migration errors.
  • Refactor
    • Enhanced contract versioning and configuration migration handling.
    • Improved logic in estimating execution buy from target by aligning quantities with market tick size requirements.
  • Tests
    • Expanded integration tests to include realistic market scenarios and contract migration tests.

This comment was marked as resolved.

coderabbitai[bot]

This comment was marked as resolved.

coderabbitai[bot]

This comment was marked as resolved.

Copy link
Contributor

@maxrobot maxrobot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments just version stuff

contracts/swap/Cargo.toml Show resolved Hide resolved
contracts/swap/Cargo.toml Outdated Show resolved Hide resolved
contracts/swap/src/contract.rs Show resolved Hide resolved
contracts/swap/src/contract.rs Show resolved Hide resolved
Copy link
Contributor

@maxrobot maxrobot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

L
G
T
M

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between 9a0b624 and c827e7f.
Files ignored due to path filters (2)
  • Cargo.lock is excluded by: !**/*.lock
  • contracts/swap/Cargo.toml is excluded by: !**/*.toml
Files selected for processing (1)
  • contracts/swap/src/contract.rs (3 hunks)
Files skipped from review as they are similar to previous changes (1)
  • contracts/swap/src/contract.rs

@gorgos gorgos merged commit be2f46d into master Feb 25, 2024
4 checks passed
@gorgos gorgos deleted the b/fix-multihop-buys branch February 25, 2024 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants