Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

F/swap routes fix #19

Merged
merged 10 commits into from
Nov 8, 2024
Merged

F/swap routes fix #19

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
0aa058f
feat: updated the swap routes query
maxrobot Oct 30, 2024
9b7fcdb
chore: move helpers
maxrobot Oct 30, 2024
fe28cfc
chore: re-org
maxrobot Oct 30, 2024
a694d8f
chore: fix integration tests
maxrobot Oct 30, 2024
255467f
feat: migration test
maxrobot Oct 31, 2024
37ad16a
chore: finish migration
maxrobot Oct 31, 2024
4db805c
chore: ci
maxrobot Oct 31, 2024
23201db
admin doc
maxrobot Oct 31, 2024
436d29d
chore: lint
maxrobot Oct 31, 2024
851e199
chore: github actions tool fix.
jbernal87 Nov 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
0 .cargo/config → .cargo/config.toml
View file
Open in desktop
File renamed without changes.
10 changes: 5 additions & 5 deletions .github/workflows/rust.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ jobs:
uses: actions-rs/toolchain@v1
with:
profile: minimal
toolchain: 1.74.0
toolchain: 1.78.0
target: wasm32-unknown-unknown
override: true
components: llvm-tools-preview
Expand Down Expand Up @@ -62,7 +62,7 @@ jobs:
uses: actions-rs/cargo@v1
with:
command: test
toolchain: 1.74.0
toolchain: 1.78.0
args: --locked --tests
env:
LLVM_PROFILE_FILE: "swap-contract-%p-%m.profraw"
Expand Down Expand Up @@ -98,7 +98,7 @@ jobs:
uses: actions-rs/toolchain@v1
with:
profile: minimal
toolchain: 1.74.0
toolchain: 1.78.0
override: true
components: rustfmt, clippy

Expand All @@ -123,13 +123,13 @@ jobs:
- name: Run cargo fmt
uses: actions-rs/cargo@v1
with:
toolchain: 1.74.0
toolchain: 1.78.0
command: fmt
args: --all -- --check

- name: Run cargo clippy
uses: actions-rs/cargo@v1
with:
toolchain: 1.74.0
toolchain: 1.78.0
command: clippy
args: --tests -- -D warnings
Comment on lines +126 to 135
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Update the actions-rs/cargo action version.

The current version of actions-rs/cargo@v1 is outdated and may have compatibility issues with the latest GitHub Actions runners.

Consider updating to a newer version of the action or switching to alternative maintained actions. For example:

-      - name: Run cargo fmt
-        uses: actions-rs/cargo@v1
+      - name: Run cargo fmt
+        uses: dtolnay/rust-toolchain@stable
+      - run: cargo fmt --all -- --check

-      - name: Run cargo clippy
-        uses: actions-rs/cargo@v1
+      - name: Run cargo clippy
+        uses: dtolnay/rust-toolchain@stable
+      - run: cargo clippy --tests -- -D warnings

This change uses the more actively maintained dtolnay/rust-toolchain action.

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
toolchain: 1.78.0
command: fmt
args: --all -- --check
- name: Run cargo clippy
uses: actions-rs/cargo@v1
with:
toolchain: 1.74.0
toolchain: 1.78.0
command: clippy
args: --tests -- -D warnings
toolchain: 1.78.0
command: fmt
args: --all -- --check
- name: Run cargo clippy
uses: dtolnay/rust-toolchain@stable
- run: cargo clippy --tests -- -D warnings
```
Note: The suggestion shows only the visible part of the code snippet, but the complete change would also need to update the cargo fmt section above in a similar manner. The full implementation would look like:
```suggestion
- name: Run cargo fmt
uses: dtolnay/rust-toolchain@stable
- run: cargo fmt --all -- --check
- name: Run cargo clippy
uses: dtolnay/rust-toolchain@stable
- run: cargo clippy --tests -- -D warnings
🧰 Tools
🪛 actionlint

131-131: the runner of "actions-rs/cargo@v1" action is too old to run on GitHub Actions. update the action's version to fix this issue

(action)

Loading
Loading