Skip to content

Commit

Permalink
Merge branch 'development' of ssh://git.devops.innovateuk.org/ifs/inn…
Browse files Browse the repository at this point in the history
…ovation-funding-service into development
  • Loading branch information
bitbucket committed Jan 8, 2021
2 parents 5170ce2 + c00ac1e commit 03a754d
Show file tree
Hide file tree
Showing 4 changed files with 28 additions and 28 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -166,7 +166,7 @@ public ServiceResult<FinanceCheckEligibilityResource> getFinanceCheckEligibility
return projectFinanceService.financeChecksDetails(projectId, organisationId).andOnSuccessReturn(projectFinance ->
new FinanceCheckEligibilityResource(project.getId(),
organisationId,
application.getDurationInMonths(),
project.getDurationInMonths(),
projectFinance.getTotal(),
projectFinance.getGrantClaimPercentage(),
projectFinance.getTotalFundingSought(),
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -350,7 +350,7 @@ public void getFinanceCheckEligibility(){

FinanceCheckEligibilityResource eligibility = result.getSuccess();

assertEquals((long) eligibility.getDurationInMonths(), 5L);
assertEquals((long) eligibility.getDurationInMonths(), 6L);
assertEquals(projectFinanceResource.getTotal(), eligibility.getTotalCost());
assertEquals(projectFinanceResource.getGrantClaimPercentage(), eligibility.getPercentageGrant());
assertEquals(projectFinanceResource.getTotalFundingSought(), eligibility.getFundingSought());
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,8 @@ Documentation INFUND-5190 As a member of Project Finance I want to view an a
...
... IFS-6893 Academic users can't see their finances in PS
...
... IFS-8695 Amending the project duration date doesn't reflect the change in other screens
...
Suite Setup Custom suite setup
Suite Teardown Close browser and delete emails
Force Tags Project Setup
Expand Down Expand Up @@ -487,13 +489,13 @@ Project finance user can see the Eligibility check page for the lead partner
Then the user should see the element jQuery = h1:contains("${EMPIRE_LTD_NAME}")

Project finance user can see the lead partner's information about eligibility
[Documentation] INFUND-4832
[Documentation] INFUND-4832 IFS-8695
[Tags]
# Note the below figures aren't calculated, but simply brought forward from user-entered input during the application phase
When the user should see the text in the element css = .table-overview tbody tr:nth-child(1) td:nth-child(1) 3 months # Project duration
When the user should see the text in the element css = .table-overview tbody tr:nth-child(1) td:nth-child(1) 4 months # Project duration
When the user should see the text in the element css = .table-overview tbody tr:nth-child(1) td:nth-child(2) £200,903 # Total costs
When the user should see the text in the element css = .table-overview tbody tr:nth-child(1) td:nth-child(3) 30.00% # Grant %
When the user should see the text in the element css = .table-overview tbody tr:nth-child(1) td:nth-child(4) 57,803 # Funding sought (£)
When the user should see the text in the element css = .table-overview tbody tr:nth-child(1) td:nth-child(3) 30.00% # Grant %
When the user should see the text in the element css = .table-overview tbody tr:nth-child(1) td:nth-child(4) 57,803 # Funding sought (£)
When the user should see the text in the element css = .table-overview tbody tr:nth-child(1) td:nth-child(5) 2,468 # Other public sector funding (£)
When the user should see the text in the element css = .table-overview tbody tr:nth-child(1) td:nth-child(6) 140,632 # Contribution to project (£)

Expand Down Expand Up @@ -655,12 +657,12 @@ Project finance user can see the partner's zero funding request
[Teardown] the user navigates to the page ${server}/project-setup-management/project/${FUNDERS_PANEL_APPLICATION_1_PROJECT}/finance-check/organisation/${organisationLudlowId}/eligibility

Project finance user can see the partner's information about eligibility
[Documentation] INFUND-4832
[Documentation] INFUND-4832 IFS-8695
[Tags]
# Note the below figures aren't calculated, but simply brought forward from user-entered input during the application phase
When the user should see the text in the element css = .table-overview tbody tr:nth-child(1) td:nth-child(1) 3 months # Project duration
When the user should see the text in the element css = .table-overview tbody tr:nth-child(1) td:nth-child(1) 4 months # Project duration
When the user should see the text in the element css = .table-overview tbody tr:nth-child(1) td:nth-child(2) £200,903 # Total costs
When the user should see the text in the element css = .table-overview tbody tr:nth-child(1) td:nth-child(3) 30.00% # Grant %
When the user should see the text in the element css = .table-overview tbody tr:nth-child(1) td:nth-child(3) 30.00% # Grant %
When the user should see the text in the element css = .table-overview tbody tr:nth-child(1) td:nth-child(4) 57,803 # Funding sought (£)
When the user should see the text in the element css = .table-overview tbody tr:nth-child(1) td:nth-child(5) 2,468 # Other public sector funding (£)
When the user should see the text in the element css = .table-overview tbody tr:nth-child(1) td:nth-child(6) 140,632 # Contribution to project (£)
Expand All @@ -683,7 +685,7 @@ Project Finance user can edit and save partner's 20% of labour costs option
And the user clicks the button/link css = [data-target = "overhead-default-percentage"] label
Then verify percentage and total Overhead costs £11,886
And the user clicks the button/link css = .govuk-button[name = "save-eligibility"]
And the user should see the element jQuery = span:contains("£11,886") ~ #accordion-finances-heading-2
And the user should see the element jQuery = span:contains("£11,886") ~ #accordion-finances-heading-2
And the user should see the element jQuery = #accordion-finances-content-2 a:contains("Edit")
Then verify total costs of project £187,717

Expand Down
Original file line number Diff line number Diff line change
@@ -1,26 +1,24 @@
*** Settings ***
Documentation IFS-8328 KTP Project Setup - finance checks (internal and external)
...
... IFS-8695 Amending the project duration date doesn't reflect the change in other screens
...
Suite Setup Custom Suite Setup
Resource ../../resources/defaultResources.robot
Resource ../../resources/common/Applicant_Commons.robot
Resource ../../resources/common/Competition_Commons.robot
Resource ../../resources/common/PS_Common.robot

*** Variables ***
${KTPapplication} KTP in panel application
${ktpProjectID} ${project_ids["${KTPapplication}"]}
${KTPapplicationId} ${application_ids["${KTPapplication}"]}
${KTPcompetiton} KTP in panel
${KTPcompetitonId} ${competition_ids["${KTPcompetiton}"]}
${ktpLeadOrgName} A base of knowledge
${ktpLeadOrgID} ${organisation_ids["${ktpLeadOrgName}"]}
${ktpPartnerOrgName} Ludlow
${ktpPartnerOrgId} ${organisation_ids["${ktpPartnerOrgName}"]}
&{FinanceUser} [email protected] password=${short_password}
&{ifsAdmin} [email protected] password=${short_password}
&{ktpLead} [email protected] password=${short_password}
&{ktpPartner} [email protected] password=${short_password}
${KTPapplication} KTP in panel application
${ktpProjectID} ${project_ids["${KTPapplication}"]}
${KTPcompetiton} KTP in panel
${KTPcompetitonId} ${competition_ids["${KTPcompetiton}"]}
${ktpLeadOrgName} A base of knowledge
${ktpLeadOrgID} ${organisation_ids["${ktpLeadOrgName}"]}
${ktpPartnerOrgName} Ludlow
${ktpPartnerOrgId} ${organisation_ids["${ktpPartnerOrgName}"]}
&{ktpLead} [email protected] password=${short_password}

*** Test Cases ***
Internal user can edit the duration of the project
Expand All @@ -31,7 +29,7 @@ Internal user can edit the duration of the project
Then The user should see the element jQuery = dt:contains("Duration") ~ dd:contains("30 months")

Internal user can edit KTP finances in project setup
[Documentation] IFS-8328
[Documentation] IFS-8328 IFS-8695
Given the user navigates to the page ${server}/project-setup-management/project/${ktpProjectID}/finance-check/organisation/${ktpLeadOrgID}/eligibility
When The user clicks the button/link jQuery = button:contains("Open all")
Then The user edits the KTP costs section
Expand Down Expand Up @@ -60,21 +58,21 @@ Internal user checks the Finance overview page

The lead checks the Finance overview page
[Documentation] IFS-8328
Given Log in as a different user [email protected] Passw0rd1357
Given Log in as a different user &{ktpLead}
And The user navigates to the page ${server}/project-setup/project/${ktpProjectID}/finance-checks
When The user clicks the button/link link = your project finance overview
Then the user verifies the values in the finance summary table after editing the project costs
And the user checks the values in the projects costs summary table
And The user clicks the button/link link = Back to finance checks

The lead checks the Eligibility check page
[Documentation] IFS-8328
[Documentation] IFS-8328 IFS-8695
When The user clicks the button/link link = review your project finances
Then the user confirms the values in the finance table

The partner checks the Finance overview page
[Documentation] IFS-8328
Given Log in as a different user [email protected] Passw0rd1357
Given Log in as a different user &{collaborator1_credentials}
And The user navigates to the page ${server}/project-setup/project/${ktpProjectID}/finance-checks
When The user clicks the button/link link = project finance overview
Then the user verifies the values in the finance summary table after editing the project costs
Expand Down Expand Up @@ -131,7 +129,7 @@ the user approves viability

the user confirms the values in the finance table
the user should see the element jQuery = th:contains("Project duration")
# the user should see the element jQuery = td:nth-child(1):contains("30 months")
the user should see the element jQuery = td:nth-child(1):contains("30 months")
the user should see the element jQuery = th:contains("Total costs")
the user should see the element jQuery = td:nth-child(2):contains("£720")
the user should see the element jQuery = th:contains("Funding level (%)")
Expand Down

0 comments on commit 03a754d

Please sign in to comment.