[X19V] refactorisation #93
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remi-Gau
commented
Sep 21, 2023
| @@ -413,10 +413,10 @@ def get_subgroups_contrasts( | |||
| if sub_id[-2][-3:] in subject_list: | |||
| varcopes_global.append(varcope) | |||
|
|
|||
| return copes_equal_indifference, copes_equal_range, | |||
| return (copes_equal_indifference, copes_equal_range, | |||
There was a problem hiding this comment.
Remove changes as they are in #92
Comment on lines
+1
to
+2
| [tool.isort] | ||
| combine_as_imports = true |
There was a problem hiding this comment.
Probably better suited in a separate pr
| @@ -7,26 +7,27 @@ | |||
| """ | |||
|
|
|||
| from os import remove | |||
| from os.path import join, isfile | |||
| from os.path import isfile, join | |||
| from pathlib import Path | |||
There was a problem hiding this comment.
Maybe only keep the changes thst relevant to this PR and not all the black related things.
|
|
||
| @fixture | ||
| def participant_tsv(bids_dir) -> Path: | ||
| """Return the participant tsv file as a DataFrame.""" |
There was a problem hiding this comment.
Not sure I used the fixture, but there may be a use case for a method in the Pipeline class to facilitate access to the actual file.
Remi-Gau
commented
Sep 21, 2023
|
|
||
| subgroups_contrasts = Node( | ||
| Function( | ||
| input_names=["copes", "varcopes", "subject_ids", "participants_file"], |
There was a problem hiding this comment.
"subject_ids", "participants_file"
those are not needed anymore: make sure that all Node definition are updated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull Request is related to issue None
Changes proposed in this Pull Request:
Checklist:
mainbranch