Translations and linting #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lugrim
force-pushed
the
translations
branch
3 times, most recently
from
639ac60 to
2153b9e
Compare
Lugrim
requested review from
ShiroUsagi-san and
Lymkwi
and removed request for
Lymkwi and
ShiroUsagi-san
Lymkwi
requested changes
Oct 10, 2023
locale/en/LC_MESSAGES/django.po
Outdated
| msgid "Demande de ré-initialisation de mot de passe" | ||
| msgstr "Ask for a password reset" | ||
|
|
||
| #: insalan/user/models.py:147 |
There was a problem hiding this comment.
For the record: this translation entry is weird but that's fine because that block of text will eventually become a document/email template
Fixed a few warnings, mostly by adding docstrings
Lymkwi
approved these changes
Oct 10, 2023
| msgid "UUID invalide" | ||
| msgstr "Invalid UUID" | ||
|
|
||
| #: tickets/views.py:32 | ||
| #: insalan/tickets/tests.py:93 insalan/tickets/views.py:32 | ||
| msgid "Utilisateur⋅ice non trouvé⋅e" |
There was a problem hiding this comment.
there are still some translation strings to fix as shown here but I guess we can do that later, that's fine
There was a problem hiding this comment.
Yup, I limited myself to the user module, that's a bottleneck for our frontend folks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added some missing translations for the
usermoduleWill also merge #57 if merged