Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added checkbox to set 'email_active' user field #72

Closed
wants to merge 1 commit into from

Conversation

TheBloodMan49
Copy link
Member

This PR simply adds a toggle in the admin panel for users.

This allows to create valid users without setting up the mailer.
Without this field set to 'true', it's impossible to log in on the front-end.

@ShiroUsagi-san
Copy link
Contributor

Is there any usage outside of the dev env?

@TheBloodMan49
Copy link
Member Author

The only one I see is manually validating players in case the mailer is down

@Lymkwi Lymkwi added enhancement New feature or request good first issue Good for newcomers priority:low Low Priority labels Oct 14, 2023
Copy link
Collaborator

@Lymkwi Lymkwi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So sadly because we are going to merge #65 first, this won't work. Can you propose another way of handling this? Perhaps a custom Django admin action to grant the right privilege?

@KwikKill KwikKill deleted the add-email-active-override branch November 16, 2023 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers priority:low Low Priority
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants