-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Limit API access #38
Merged
Merged
Limit API access #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pixup1
reviewed
Oct 25, 2024
KwikKill
force-pushed
the
netcontrol-access
branch
from
October 28, 2024 14:42
e3d015e
to
ca94390
Compare
pixup1
requested changes
Nov 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use an nftable at launch to limit interaction to loaclhost addresses only. Scrap the bash script.
InsaLan-Serveurs
force-pushed
the
netcontrol-access
branch
from
November 14, 2024 10:52
fb30221
to
a2f68f9
Compare
pixup1
approved these changes
Nov 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✨✨ 🄻🅶🅃🅼 ✨✨
KwikKill
pushed a commit
that referenced
this pull request
Nov 21, 2024
* First attempt at limiting acces to fastapi * Swith to bash * Change to a nft rule * Fix nft rule * Clean netcontrol access rule --------- Co-authored-by: Ecnama <[email protected]> Co-authored-by: Claptrap <[email protected]>
KwikKill
pushed a commit
that referenced
this pull request
Nov 21, 2024
* First attempt at limiting acces to fastapi * Swith to bash * Change to a nft rule * Fix nft rule * Clean netcontrol access rule --------- Co-authored-by: Ecnama <[email protected]> Co-authored-by: Claptrap <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Forbids outside access to the API by binding Fastapi to the docker bridge IP.
Checklist