BUG: Fix duplicate test output filename #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix duplicate test output filename: tests `IOOMEZarrNGFF_readTimeIndex0` and `IOOMEZarrNGFF_readTimeIndex1` were using the same outputfilenames, and some CI builds were failing probably because they were trying to read/write to the same location. Fixes: ``` Exception detected while reading ITKIOOMEZarrNGFF/build/ExternalData/test/Baseline/simple_tyx_t0.mha : Could not create IO object for reading file ITKIOOMEZarrNGFF/build/Testing/Temporary/IOOMEZarrNGFF/simple_tyx_t0.mha ``` raised for example at: https://github.com/InsightSoftwareConsortium/ITKIOOMEZarrNGFF/actions/runs/9648607798/job/26615199448#step:15:223
|
brilliant @jhlegarreta ! 🦅 👁️ |
thewtex
approved these changes
Jun 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix duplicate test output filename: tests
IOOMEZarrNGFF_readTimeIndex0andIOOMEZarrNGFF_readTimeIndex1were using the same outputfilenames, and some CI builds were failing probably because they were trying to read/write to the same location.Fixes:
raised for example at:
https://github.com/InsightSoftwareConsortium/ITKIOOMEZarrNGFF/actions/runs/9648607798/job/26615199448#step:15:223