Add supportedPixelTypes typelist, replace ELEMENT_WRITE with TryToWriteToStore
#69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
N-Dekker
commented
Aug 21, 2024
N-Dekker
commented
- Follow-up to pull request Replace READ_ELEMENT_IF with variadic template, move functions into unnamed namespace #67
Avoided a few redundant `this->GetComponentType()` calls.
dzenanz
approved these changes
Aug 21, 2024
N-Dekker
force-pushed
the
Replace-ELEMENT_WRITE-macro
branch
from
1572fb8
to
b24fc51
Compare
|
"Build, test, package / build-test-cxx (macos-12) (pull_request)" failed saying (https://github.com/InsightSoftwareConsortium/ITKIOOMEZarrNGFF/actions/runs/10498234014/job/29082765516#step:11:1062): It cannot find Update: Looks like this was some "hick-up" of the CI system! With the latest force-push, it just works fine 😃 |
Anticipated sharing the list of supported pixel types between `OMEZarrNGFFImageIO::Read` and `OMEZarrNGFFImageIO::Write`
Allowed the macro to be called anywhere in the source file.
Allowed `getKVstoreDriver` to be called by other functions from the unnamed namespace more easily. Following C++ Core Guidelines, May 11, 2024, "Use an unnamed (anonymous) namespace for all internal/non-exported entities", http://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#sf22-use-an-unnamed-anonymous-namespace-for-all-internalnon-exported-entities
Replaced the original `ELEMENT_WRITE` macro with a variadic template, using a C++17 fold-expression. Follow-up to pull request InsightSoftwareConsortium#67 commit 77a2f45 "STYLE: Replace READ_ELEMENT_IF with TryToReadFromStore variadic template"
N-Dekker
force-pushed
the
Replace-ELEMENT_WRITE-macro
branch
from
b24fc51
to
679a165
Compare
dzenanz
approved these changes
Aug 22, 2024
|
Thanks for your approval, @dzenanz. I also think this PR is ready 😃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.