Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: DOC: Reload examples page if itkwidgets[lab] installed later #600

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

thewtex
Copy link
Member

@thewtex thewtex commented Jan 17, 2023

If the imjoy jupyterlab extension is installed after JupyterLab has been loaded, the page needs to be reloaded to load up the added JavaScript.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@bnmajor
Copy link
Collaborator

bnmajor commented Jan 17, 2023

@thewtex In my testing this works exactly as expected for locally hosted jupyter instances but not in SageMaker... It prompts to refresh as expected but refreshing does not make the extension available and the viewer is still not output. Trying to pin down the why.

If the imjoy jupyterlab extension is installed after JupyterLab has been
loaded, the page needs to be reloaded to load up the added JavaScript.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants