Add docs gitignores #411
Closed
Add docs gitignores #411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ucts without modifying the base project's .gitignores. Initially adding the tutorial build products.
JSchripsema-IDM
approved these changes
Oct 31, 2023
|
Thanks @bryanressler-idmod ! Good idea to have a docs-specific |
|
I thought the entire docs/tutorials folder was generated. If only parts are generated, I will revise the PR.
Thanks for the headsup Cliff!
…-Bryan
________________________________
From: Cliff Kerr ***@***.***>
Sent: Wednesday, November 1, 2023 6:57 AM
To: InstituteforDiseaseModeling/covasim ***@***.***>
Cc: Bryan Ressler ***@***.***>; Mention ***@***.***>
Subject: Re: [InstituteforDiseaseModeling/covasim] Add docs gitignores (PR #411)
Thanks @bryanressler-idmod<https://github.com/bryanressler-idmod> ! Good idea to have a docs-specific .gitignore. I don't think we want to ignore tutorials though, do we? (I also need to fix the failing tests here, which needless to say are not the fault of this PR!)
—
Reply to this email directly, view it on GitHub<#411 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AFRBGEZE47MLELWKIMR2PHLYCJILJAVCNFSM6AAAAAA6YNTG6SVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTOOBZGAYDENRZGY>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
|
A few example files are generated when the tutorials are built, but otherwise none of it is autogenerated if I remember correctly! |
|
My bad. I will revise the PR.
Thanks again,
Bryan
…________________________________
From: Cliff Kerr ***@***.***>
Sent: Wednesday, November 1, 2023 9:57 AM
To: InstituteforDiseaseModeling/covasim ***@***.***>
Cc: Bryan Ressler ***@***.***>; Mention ***@***.***>
Subject: Re: [InstituteforDiseaseModeling/covasim] Add docs gitignores (PR #411)
A few example files are generated when the tutorials are built, but otherwise none of it is autogenerated if I remember correctly!
—
Reply to this email directly, view it on GitHub<#411 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AFRBGE6ZN3KLEJWN7Z45M7TYCJ5RLAVCNFSM6AAAAAA6YNTG6SVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTOOBZGMYTKMZTHA>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
|
Sorry, I should have caught that! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a docs/.gitignores to allow docs to ignore some docs build projects without changing the base project .gitignores.