Skip to content
This repository has been archived by the owner on Dec 15, 2022. It is now read-only.

Disable mandatory decoding with utf-8 #278

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Disable mandatory decoding with utf-8 #278

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion common/helper.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -649,7 +649,6 @@ def cmd_exec(cmd, env=None, cwd=None, shell=True, log=None, verbose=True, hide=N
check=True,
stdout=subprocess.PIPE,
stderr=subprocess.STDOUT,
encoding='utf-8',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not quite good idea to disable encoding.
Need to be shure that output has correct format.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree. Should be added default parameter in this case.

errors='backslashreplace')

return completed_process.returncode, completed_process.stdout
Expand Down