-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce DPCTL_WITH_REDIST cmake option to fix #1893
base: master
Are you sure you want to change the base?
Conversation
Deduplicated common steps among two pybind11 extensions in this dpctl.utils Fixed typo CUMAKE_CURRENT_SOURCE_DIR -> CMAKE_CURRENT_SOURCE_DIR
View rendered docs @ https://intelpython.github.io/dpctl/pulls/1893/index.html |
Array API standard conformance tests for dpctl=0.19.0dev0=py310hdf72452_212 ran successfully. |
I can see that RUNPATH is set as expected in conda package:
but it is not set correctly in the wheels built by our CI (wheel is built in
|
Array API standard conformance tests for dpctl=0.19.0dev0=py310hdf72452_214 ran successfully. |
…e preceding comment
…e preceding comment
Array API standard conformance tests for dpctl=0.19.0dev0=py310hdf72452_218 ran successfully. |
Array API standard conformance tests for dpctl=0.19.0dev0=py310hdf72452_219 ran successfully. |
This PR has fixed the issue now:
Both |
Closes gh-1892
This PR introduced
DPCTL_WITH_REDIST
cmake options, defaulting toOFF
.If set, cmake script add to RUNPATH an entry relative to
$ORIGIN
that would point to$PREFIX/lib
, hence allowing native extensions to find DPC++ redistributable libraries.conda-recipe/build.sh
is modified to setDPCTL_WITH_REDIST=TRUE
.