Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix direction changes for //undo #2972

Merged
merged 1 commit into from
Nov 4, 2024
Merged

Conversation

SirYwell
Copy link
Member

@SirYwell SirYwell commented Nov 1, 2024

Overview

Fixes #2971

Description

With the coordinated undo, we now reuse MutableTileChange and MutableEntityChange across create and remove changes. This however requires us to also adjust the change in that regard. Unconditionally writing the currently expected value is most likely the simplest solution.

This is not a problem for other change types as we don't have the create/remove situation there.

Submitter Checklist

Preview Give feedback

@SirYwell SirYwell requested a review from a team as a code owner November 1, 2024 10:38
@github-actions github-actions bot added the Bugfix This PR fixes a bug label Nov 1, 2024
@dordsor21 dordsor21 requested a review from a team November 1, 2024 11:04
@dordsor21 dordsor21 merged commit 9eafbf1 into main Nov 4, 2024
9 checks passed
@dordsor21 dordsor21 deleted the fix/mutable-change-direction branch November 4, 2024 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bugfix This PR fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clobbered block data cannot be undone (sometimes)
3 participants