-
-
Notifications
You must be signed in to change notification settings - Fork 236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build a Mojang mapped jar in addition to the reobf one, publish both to Modrinth with correct metadata #2981
Build a Mojang mapped jar in addition to the reobf one, publish both to Modrinth with correct metadata #2981
Conversation
00deb25
to
9a34d9f
Compare
Please take a moment and address the merge conflicts of your pull request. Thanks! |
…to Modrinth with correct metadata
…ar for their Minecraft version and platform combination
9a34d9f
to
832d61e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
@NotMyFault strange, I would try using the id instead of the name: z4HZZnLr |
Thanks for the pointer, where did you get the ID from? |
Overview
Removes the need for remapping on Paper, reducing disk usage and first-start times.
Description
The project now builds two ShadowJars, one for Paper 1.20.5+ only (Mojmapped), and one that will work on Spigot or Paper for all versions (Spigot mapped).
We publish the Spigot jar to Modrinth twice to make sure their version selector picks the right jar for the platform regardless of the Minecraft version.
I've also added a runtime check on startup to notify the user when they have the wrong jar for their platform, tested with:
I'm also wondering if it's intentional that 1.20.4 is not in the supported list for Modrinth publishing but 1.20.3 and 1.19.4 are. Let me know and I can adjust this if needed.
I've updated the GitHub Actions, not sure if Jenkins will need changes or not.
Submitter Checklist
@since TODO
.