Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix //snow #3019

Merged
merged 3 commits into from
Dec 11, 2024
Merged

Fix //snow #3019

merged 3 commits into from
Dec 11, 2024

Conversation

PierreSchwang
Copy link
Member

Overview

#2976 seems to have introduced a regression - which should be fixed now

Description

  • Updated #isFullBlock to actually check for the VoxelShape and not the occlusion of the block
  • Updated SnowSimulator to make it more readable (hopefully?) and following Minecrafts snow / rain ticking logic closer

Submitter Checklist

Preview Give feedback

@PierreSchwang PierreSchwang requested a review from a team as a code owner December 6, 2024 00:45
@github-actions github-actions bot added the Bugfix This PR fixes a bug label Dec 6, 2024
@NotMyFault NotMyFault requested a review from a team December 7, 2024 17:34
@PierreSchwang PierreSchwang merged commit b548219 into main Dec 11, 2024
11 checks passed
@PierreSchwang PierreSchwang deleted the fix/snowSimulator branch December 11, 2024 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bugfix This PR fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants