Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pp): fix pp get tensor shape err and layernorm input dtype err #378

Merged
merged 2 commits into from
Dec 10, 2024

Conversation

huangting4201
Copy link
Collaborator

@huangting4201 huangting4201 commented Dec 2, 2024

Motivation

  1. Fix pipeline scheduler get_tensor_shape func when global var SEQ_LEN or HIDDEN_SIZE is not init.
  2. Fix layernorm input dtype.

Modification

internlm/core/scheduler/pipeline_scheduler_1f1b.py: get_tensor_shape()

BC-breaking (Optional)

Does the modification introduce changes that break the backward compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here and update the documentation.

Checklist

Before PR:

  • Pre-commit or other linting tools are used to fix the potential lint issues.
  • Bug fixes are fully covered by unit tests, the case that causes the bug should be added in the unit tests.
  • The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  • The documentation has been modified accordingly, like docstring or example tutorials.

After PR:

  • If the modification has potential influence on downstream or other related projects, this PR should be tested with those projects.
  • CLA has been signed and all committers have signed the CLA in this PR.

@huangting4201 huangting4201 assigned sunpengsdu and unassigned yhcc Dec 2, 2024
@huangting4201 huangting4201 requested a review from mwiacx December 2, 2024 09:23
@mwiacx
Copy link
Contributor

mwiacx commented Dec 3, 2024

/LGTM

@huangting4201 huangting4201 changed the title fix(pp): fix pp get tensor shape err when global SEQ_LEN or HIDDEN_SIZE is not init fix(pp): fix pp get tensor shape err and layernorm input dtype err Dec 3, 2024
@huangting4201 huangting4201 added the bug Something isn't working label Dec 3, 2024
@huangting4201
Copy link
Collaborator Author

@kkscilife 因为修复了bug,造成loss精度的测例不通过,需要梦珂帮忙适配下loss失败的测例

@sunpengsdu sunpengsdu merged commit 5ad2eb0 into InternLM:develop Dec 10, 2024
17 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants