Add warning when username starts with a lowercase letter #194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Warning for people who select a username starting with a lowercase letter
mrsrec
changed the title
|
Closes #193 |
jacob-g
requested changes
Dec 6, 2023
jacob-g
reviewed
Dec 6, 2023
Co-authored-by: AbyxDev <[email protected]>
jacob-g
reviewed
Mar 12, 2024
resources/main.js
Outdated
|
|
||
| elem.onblur = function() { | ||
| var currentname = elem.value || ""; | ||
| var usernameblock = new OO.ui.infuse(elem.parentElement.parentElement.parentElement.parentElement); |
There was a problem hiding this comment.
Would it be possible to use .closest instead of this? This seems janky and likely to break with some OOUI update.
jacob-g
requested changes
Mar 12, 2024
|
@jacob-g I'm not familiar with .closest but I don't think it's likely to break. Generally the only thing that can break is hardcoding element names (like "ooui-php-1"), but just the number of elements is fine. I will look into .closest more if it's important. |
|
You can use this: document.getElementsByName("scratchusername")[0].closest('.oo-ui-layout')This both is less likely to break if OOUI introduces any change and more properly conveys the abstraction of trying to find the wrapping layout. |
|
@jacob-g OK. Added but not tested. |
|
Seems to be working now.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Warning for people who select a username starting with a lowercase letter