-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate latest ledger and ouroboros-consensus for 8.6 #321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teodanciu
force-pushed
the
td/ledger-and-consensus-for-8.6
branch
from
October 17, 2023 11:19
9b2d3d4
to
001d9c0
Compare
teodanciu
force-pushed
the
td/ledger-and-consensus-for-8.6
branch
from
October 17, 2023 11:33
001d9c0
to
f9a42c7
Compare
teodanciu
force-pushed
the
td/ledger-and-consensus-for-8.6
branch
4 times, most recently
from
October 17, 2023 13:52
4a7ee97
to
20bc444
Compare
teodanciu
force-pushed
the
td/ledger-and-consensus-for-8.6
branch
10 times, most recently
from
October 19, 2023 11:43
ce1b27e
to
289d57e
Compare
teodanciu
changed the title
Integrate latest ledger and ouroboros-consensus for 8.6.0-pre - SRP
Integrate latest ledger and ouroboros-consensus for 8.6.0-pre - SRP (based on cardano-api-8.26.0.0)
Oct 19, 2023
smelc
approved these changes
Oct 19, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not familiar with the changes to PParamsUpdate
and withProtVer
but the rest looks good to me 👍
teodanciu
changed the title
Integrate latest ledger and ouroboros-consensus for 8.6.0-pre - SRP (based on cardano-api-8.26.0.0)
Integrate latest ledger and ouroboros-consensus for 8.6.0- SRP (based on cardano-api-8.26.0.0)
Oct 19, 2023
teodanciu
force-pushed
the
td/ledger-and-consensus-for-8.6
branch
4 times, most recently
from
October 19, 2023 17:46
9e1f564
to
83a0652
Compare
teodanciu
changed the title
Integrate latest ledger and ouroboros-consensus for 8.6.0- SRP (based on cardano-api-8.26.0.0)
Integrate latest ledger and ouroboros-consensus for 8.6.0- SRP (based on cardano-api-8.27.0.0)
Oct 19, 2023
Jimbo4350
reviewed
Oct 19, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a few comments
teodanciu
force-pushed
the
td/ledger-and-consensus-for-8.6
branch
from
October 19, 2023 18:59
83a0652
to
2b8800e
Compare
teodanciu
requested review from
a team,
dcoutts,
erikd,
newhoggy,
carbolymer,
CarlosLopezDeLara and
disassembler
as code owners
October 26, 2023 16:28
which is reflecting the fact that in Conway, protocol version cannot be changed via PParamsUpdate.
teodanciu
force-pushed
the
td/ledger-and-consensus-for-8.6
branch
2 times, most recently
from
October 26, 2023 22:20
31f0f31
to
8fd4dad
Compare
from Strict Seq to OSet
teodanciu
force-pushed
the
td/ledger-and-consensus-for-8.6
branch
from
October 26, 2023 22:55
8fd4dad
to
2478f54
Compare
newhoggy
approved these changes
Oct 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog
Context
Release node 8.6
Checklist
See Running tests for more details
.cabal
files are updatedhlint
. See.github/workflows/check-hlint.yml
to get thehlint
versionstylish-haskell
. See.github/workflows/stylish-haskell.yml
to get thestylish-haskell
versionghc-8.10.7
andghc-9.2.7