Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add instance ToCardanoEra Exp.Era #680

Closed
wants to merge 1 commit into from

Conversation

smelc
Copy link
Contributor

@smelc smelc commented Nov 14, 2024

Changelog

- description: |
    Add instance ToCardanoEra Exp.Era
# uncomment types applicable to the change:
  type:
  # - feature        # introduces a new feature
  # - breaking       # the API has changed in a breaking way
  - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  # - refactoring    # QoL changes
  # - bugfix         # fixes a defect
  # - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

Required for IntersectMBO/cardano-cli#968

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • Self-reviewed the diff

Comment on lines +238 to +239
instance Api.ToCardanoEra Era where
toCardanoEra = \case
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, this got merged 😎 so you can use inject instead. 😃

@smelc
Copy link
Contributor Author

smelc commented Nov 15, 2024

Closing as this is superseded by #636

Thanks @carbolymer for the remark ❤️

@smelc smelc closed this Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants