Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drep id: have --output-bech32 and --output-hex instead of --output-format STRING #1017

Merged
merged 3 commits into from
Jan 13, 2025

Conversation

smelc
Copy link
Contributor

@smelc smelc commented Jan 10, 2025

Changelog

- description: |
    drep id: have --output-bech32 and --output-hex instead of --output-format STRING 
# uncomment types applicable to the change:
  type:
  # - feature        # introduces a new feature
  - breaking       # the API has changed in a breaking way
  # - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  # - refactoring    # QoL changes
  # - bugfix         # fixes a defect
  # - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

How to trust this PR

Look at the changes to golden files

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • Self-reviewed the diff

Copy link
Contributor

@palas palas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Copy link
Contributor

@carbolymer carbolymer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, I like it.

@smelc smelc enabled auto-merge January 10, 2025 13:45
@smelc smelc added this pull request to the merge queue Jan 10, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Jan 10, 2025
@smelc smelc added this pull request to the merge queue Jan 13, 2025
Merged via the queue into master with commit 8e82b71 Jan 13, 2025
41 of 80 checks passed
@smelc smelc deleted the smelc/drep-id-fixed-flags-not-flags-STRING branch January 13, 2025 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

drep id: have --output-hex and --output-bech32 instead of --output-format [hex|bech32]
3 participants