Query a node for a snapshot of big ledger peers #727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crocodile-dentist
requested review from
Jimbo4350,
newhoggy,
carbolymer,
smelc,
palas,
kevinhammond and
disassembler
as code owners
crocodile-dentist
force-pushed
the
mwojtowicz/ledger-query-peer-snapshot
branch
from
d331184
to
141ce47
Compare
carbolymer
approved these changes
Apr 18, 2024
smelc
approved these changes
Apr 19, 2024
crocodile-dentist
force-pushed
the
mwojtowicz/ledger-query-peer-snapshot
branch
from
141ce47
to
ab2200d
Compare
|
This PR is stale because it has been open 45 days with no activity. |
crocodile-dentist
force-pushed
the
mwojtowicz/ledger-query-peer-snapshot
branch
from
ab2200d
to
846fbcb
Compare
|
Seems this is blocked on updated in https://github.com/IntersectMBO/ouroboros-network, so putting as draft until this is really mergeable. @crocodile-dentist> please undraft when this is close to being merged. |
crocodile-dentist
force-pushed
the
mwojtowicz/ledger-query-peer-snapshot
branch
3 times, most recently
from
1a78bfc
to
913c44d
Compare
palas
force-pushed
the
mwojtowicz/ledger-query-peer-snapshot
branch
2 times, most recently
from
36449ee
to
cb5eebc
Compare
|
FYI: I have rebased your branch because we have done changes to the formatting. I have made a copy of the unrebased branch that you can find in my previous comment in this PR. |
crocodile-dentist
force-pushed
the
mwojtowicz/ledger-query-peer-snapshot
branch
from
cb5eebc
to
72a6466
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
crocodile-dentist
force-pushed
the
mwojtowicz/ledger-query-peer-snapshot
branch
from
72a6466
to
7e4c792
Compare
This change introduces query subcommand ledger-peer-snapshot to serialize a snapshot of big ledger peers from the tip of the current chain.
crocodile-dentist
force-pushed
the
mwojtowicz/ledger-query-peer-snapshot
branch
from
7e4c792
to
00a96fb
Compare
|
This PR is stale because it has been open 45 days with no activity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog
Context
A new query subcommand ledger-peer-snapshot was introduced to serialize a snapshot of big ledger peers. These relays will be relied on by network layer when a node is syncing up in Genesis consensus mode, since a node may not have any or up to date information from its own ledger which are the big ledger peer relays.
Closes #571
Checklist