Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable aarch64-linux but disable it in hydra #837

Merged
merged 1 commit into from
Jul 16, 2024

Conversation

carbolymer
Copy link
Contributor

@carbolymer carbolymer commented Jul 15, 2024

Changelog

- description: |
    Enable aarch64-linux but disable it in hydra
# uncomment types applicable to the change:
  type:
  # - feature        # introduces a new feature
  # - breaking       # the API has changed in a breaking way
  # - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  # - refactoring    # QoL changes
  # - bugfix         # fixes a defect
  # - test           # fixes/modifies tests
   - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

We don't have aarch64-linux native builders for now. This PR simply enables this architecture in flake, but it does not build it in hydra.

Fixes #805.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. See Running tests for more details
  • Self-reviewed the diff

@carbolymer carbolymer requested review from a team as code owners July 15, 2024 16:18
flake.nix Outdated Show resolved Hide resolved
@carbolymer carbolymer force-pushed the mgalazyn/chore/enable-aarch64-linux branch from 5baca1b to 4ebec9c Compare July 15, 2024 16:21
@palas
Copy link
Contributor

palas commented Jul 15, 2024

@palas palas force-pushed the mgalazyn/chore/enable-aarch64-linux branch from 4ebec9c to 846cec1 Compare July 15, 2024 22:16
@palas
Copy link
Contributor

palas commented Jul 15, 2024

FYI: I have rebased your branch because we have done changes to the formatting. I have made a copy of the unrebased branch that you can find in my previous comment in this PR.

@carbolymer carbolymer force-pushed the mgalazyn/chore/enable-aarch64-linux branch from 846cec1 to a3f577d Compare July 16, 2024 07:49
@carbolymer carbolymer force-pushed the mgalazyn/chore/enable-aarch64-linux branch from a3f577d to a80426f Compare July 16, 2024 08:08
@carbolymer carbolymer added this pull request to the merge queue Jul 16, 2024
Merged via the queue into main with commit e5bb0ad Jul 16, 2024
24 checks passed
@carbolymer carbolymer deleted the mgalazyn/chore/enable-aarch64-linux branch July 16, 2024 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FR] - Support aarch64-linux in Nix Flake
3 participants