-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add older eras deprecation notice. #879
Add older eras deprecation notice. #879
Conversation
fa2fb6d
to
fc4f649
Compare
89ab15b
to
df3f3a6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but a couple of comments to consider
|
||
defaultShelleyToBabbageEra :: EraInEon ShelleyToBabbageEra | ||
defaultShelleyToBabbageEra = EraInEon ShelleyToBabbageEraBabbage | ||
defaultShelleyBasedEra = EraInEon ShelleyBasedEraConway |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is fine for now but I think we should demand the user specify the era. Otherwise we have to plan a release around this value which is cumbersome.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
100%. Actually, this default value is used only in legacy hierarchy, so actually this change is wrong. We don't want to change a default there. I'll revert to Babbage.
...no-cli/test/cardano-cli-golden/Test/Golden/Shelley/TextEnvelope/Certificates/StakeAddress.hs
Outdated
Show resolved
Hide resolved
...no-cli/test/cardano-cli-golden/Test/Golden/Shelley/TextEnvelope/Certificates/StakeAddress.hs
Outdated
Show resolved
Hide resolved
40394a3
to
26061be
Compare
26061be
to
25fcdff
Compare
Changelog
Context
Additional context for the PR goes here. If the PR fixes a particular issue please provide a link to the issue.
How to trust this PR
Highlight important bits of the PR that will make the review faster. If there are commands the reviewer can run to observe the new behavior, describe them.
Checklist