Options: avoid code duplication

[smelc]

Changelog

- description: |
    Share code in parsers, by using cardano-api's [parseFilePath](https://github.com/IntersectMBO/cardano-api/blob/bf84187ae986f9a2621c55b690638fe8bb2cb156/cardano-api/internal/Cardano/Api/Utils.hs#L97) instead of duplicating its implementation in 50+ places.
# uncomment types applicable to the change:
  type:
  # - feature        # introduces a new feature
  # - breaking       # the API has changed in a breaking way
  # - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  - refactoring    # QoL changes
  # - bugfix         # fixes a defect
  # - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

Improvement found when starting to write https://github.com/input-output-hk/cardano-node-wiki/pull/52/files

How to trust this PR

You can review the diff in Haskell files manually.

This question is more tricky for the 700+ golden files that have changed 😄 What I did is that I ran the golden tests against a modified version of cardano-api, at revision https://github.com/IntersectMBO/cardano-api/tree/bf84187ae986f9a2621c55b690638fe8bb2cb156. I changed this line of parseFilePath so that it used FILE as the metavariable name. This way the diff is greatly reduced, because FILE was the existing metavariable used so far most of the time. I then reviewed the golden files changes manually and everything was good.

Checklist

• Commit sequence broadly makes sense and commits have useful messages
• Self-reviewed the diff

[carbolymer]

Nice work! There are some HLint warnings though.

[carbolymer]

I know that it was copied from before, but I'm not sure about this haskell bit in the documentation: (File () Out). Seems odd, and not really informative for people not familiar with cardano-cli codebase.

[smelc]

Good point, I changed the message 👍

[carbolymer]

Nice, I didn't know we had this function. I guess we should move it from cardano-api to cardano-cli and don't depend on optparse-applicative in cardano-api.

[smelc]

Good point, I'm looking whether we can do that easily 👍

[smelc]

Follow-up PRs: IntersectMBO/cardano-api#635 and #894