Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add hash checks for drep registration-certificate and drep update-certificate #916

Merged
merged 3 commits into from
Oct 8, 2024
Merged

Add hash checks for drep registration-certificate and drep update-certificate #916

merged 3 commits into from
Oct 8, 2024

Conversation

palas
Copy link
Contributor

@palas palas commented Sep 25, 2024 •
edited
Loading

Changelog

- description: |
    Added hash checks for `drep registration-certificate` and `drep update-certificate`
  type:
  - feature        # introduces a new feature
  - breaking       # the API has changed in a breaking way
  - test           # fixes/modifies tests

Context

This is another step forward on addressing #882.

Previous related PR: #915

This only adds checks to commands inside governance drep. There are several other places where to add the check, but better to go step by step.

How to trust this PR

I have adapted test for all commands but one, to validate the new functionality, and that gives me a lot of confidence. I would try to check that the code style is good, I didn't introduce any bugs, the parameter structure and names make sense, and the help is comprehensive and comprehensible.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. See Running tests for more details
  • Self-reviewed the diff

@palas palas added enhancement New feature or request test Modifies/extends the test suite labels Sep 25, 2024
@palas palas self-assigned this Sep 25, 2024
@palas palas linked an issue Sep 25, 2024 that may be closed by this pull request
[FR] - Add File Hash Validation when Building Transaction #882
Closed
@palas palas requested review from a team as code owners September 30, 2024 16:13
Jimbo4350
Jimbo4350 requested changes Sep 30, 2024
View reviewed changes
cardano-cli/test/cardano-cli-golden/Test/Golden/Governance/DRep.hs Outdated Show resolved Hide resolved
cardano-cli/test/cardano-cli-golden/Test/Golden/Governance/DRep.hs Outdated Show resolved Hide resolved
cardano-cli/test/cardano-cli-golden/Test/Golden/Governance/DRep.hs Outdated Show resolved Hide resolved
cardano-cli/test/cardano-cli-golden/Test/Golden/Governance/DRep.hs Outdated Show resolved Hide resolved
cardano-cli/test/cardano-cli-golden/Test/Golden/Governance/DRep.hs Outdated Show resolved Hide resolved
cardano-cli/src/Cardano/CLI/EraBased/Options/Common.hs Outdated Show resolved Hide resolved
cardano-cli/src/Cardano/CLI/EraBased/Run/Governance/DRep.hs Outdated Show resolved Hide resolved
cardano-cli/src/Cardano/CLI/EraBased/Run/Governance/DRep.hs Outdated Show resolved Hide resolved
@palas palas force-pushed the add-hash-validation3 branch 2 times, most recently from 7aa748c to eebcbd8 Compare September 30, 2024 19:08
@palas palas force-pushed the add-hash-validation3 branch 2 times, most recently from f631392 to 8a86ea8 Compare October 2, 2024 22:38
@palas palas changed the base branch from main to add-hash-validation2.5 October 2, 2024 23:00
@palas palas force-pushed the add-hash-validation3 branch 2 times, most recently from cb78b02 to e1ec7c8 Compare October 3, 2024 15:34
@Jimbo4350 Jimbo4350 self-requested a review October 3, 2024 16:42
Base automatically changed from add-hash-validation2.5 to main October 3, 2024 17:41
Jimbo4350
Jimbo4350 approved these changes Oct 4, 2024
View reviewed changes
Copy link
Contributor

@Jimbo4350 Jimbo4350 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! A few comments but it can be merged 👍

...est/cardano-cli-golden/files/golden/help/latest_governance_drep_registration-certificate.cli Outdated Show resolved Hide resolved
cardano-cli/test/cardano-cli-test-lib/Test/Cardano/CLI/Hash.hs Show resolved Hide resolved
cardano-cli/test/cardano-cli-test/Test/Cli/Governance/DRep.hs Show resolved Hide resolved
@palas palas enabled auto-merge October 7, 2024 21:51
@palas palas added this pull request to the merge queue Oct 8, 2024
@palas palas removed this pull request from the merge queue due to a manual request Oct 8, 2024
@palas palas added this pull request to the merge queue Oct 8, 2024
Merged via the queue into main with commit f9202a3 Oct 8, 2024
27 checks passed
@palas palas deleted the add-hash-validation3 branch October 8, 2024 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jimbo4350 Jimbo4350 Jimbo4350 approved these changes

@newhoggy newhoggy Awaiting requested review from newhoggy

@kevinhammond kevinhammond Awaiting requested review from kevinhammond

@disassembler disassembler Awaiting requested review from disassembler

@smelc smelc Awaiting requested review from smelc

@carbolymer carbolymer Awaiting requested review from carbolymer

Assignees

@palas palas

Labels
enhancement New feature or request test Modifies/extends the test suite
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FR] - Add File Hash Validation when Building Transaction
4 participants
@palas @carbolymer @smelc @Jimbo4350