Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move node commands to top level #929

Merged
merged 4 commits into from
Oct 8, 2024
Merged

Conversation

Jimbo4350
Copy link
Contributor

@Jimbo4350 Jimbo4350 commented Oct 7, 2024

Partly resolves: #926

Changelog

- description: |
    The node commands are era agnostic and should be moved to the top level
# uncomment types applicable to the change:
  type:
  - feature        # introduces a new featur
  - compatible     # the API has changed but is non-breaking

Context

Additional context for the PR goes here. If the PR fixes a particular issue please provide a link to the issue.

How to trust this PR

Highlight important bits of the PR that will make the review faster. If there are commands the reviewer can run to observe the new behavior, describe them.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. See Running tests for more details
  • Self-reviewed the diff

@Jimbo4350 Jimbo4350 force-pushed the jordan/move-node-cmds-to-top-level branch from fe6db73 to 93b567a Compare October 7, 2024 19:19
@Jimbo4350 Jimbo4350 force-pushed the jordan/move-node-cmds-to-top-level branch 2 times, most recently from 57d9acc to 394601a Compare October 7, 2024 19:50
@Jimbo4350 Jimbo4350 marked this pull request as ready for review October 7, 2024 19:52
@smelc
Copy link
Contributor

smelc commented Oct 8, 2024

@Jimbo4350> how about moving debug check-node-configuration (i.e. #923) to node check-configuration?

@Jimbo4350
Copy link
Contributor Author

@Jimbo4350> how about moving debug check-node-configuration (i.e. #923) to node check-configuration?

Sure. In a follow up PR.

@Jimbo4350 Jimbo4350 force-pushed the jordan/move-node-cmds-to-top-level branch from 394601a to 782effd Compare October 8, 2024 13:00
@Jimbo4350 Jimbo4350 enabled auto-merge October 8, 2024 13:00
@Jimbo4350 Jimbo4350 disabled auto-merge October 8, 2024 13:01
@Jimbo4350 Jimbo4350 force-pushed the jordan/move-node-cmds-to-top-level branch from 782effd to 9f647f3 Compare October 8, 2024 13:06
@Jimbo4350 Jimbo4350 enabled auto-merge October 8, 2024 13:06
@Jimbo4350 Jimbo4350 force-pushed the jordan/move-node-cmds-to-top-level branch from 9f647f3 to 3d0356e Compare October 8, 2024 13:54
@Jimbo4350 Jimbo4350 force-pushed the jordan/move-node-cmds-to-top-level branch from 3d0356e to a1be355 Compare October 8, 2024 14:56
@Jimbo4350 Jimbo4350 added this pull request to the merge queue Oct 8, 2024
Merged via the queue into main with commit 39336fe Oct 8, 2024
25 checks passed
@Jimbo4350 Jimbo4350 deleted the jordan/move-node-cmds-to-top-level branch October 8, 2024 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] - cardano-cli compatibility command
3 participants