Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes test issues arising from integration of plutus 1.36 and latest ledger for 10.0 release #940

Merged
merged 2 commits into from
Oct 17, 2024

Conversation

crocodile-dentist
Copy link
Contributor

@crocodile-dentist crocodile-dentist commented Oct 17, 2024

Changelog

- description: |
    Integrates updated ledger type and fixes test due to new plutus ops
    Update to cardano-api-10.0 [CHANGELOG](https://github.com/IntersectMBO/cardano-api/blob/main/cardano-api/CHANGELOG.md#10000)
# uncomment types applicable to the change:
  type:
   - feature        # introduces a new feature
   - breaking       # the API has changed in a breaking way
  # - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  # - refactoring    # QoL changes
  # - bugfix         # fixes a defect
   - test           # fixes/modifies tests
   - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. See Running tests for more details
  • Self-reviewed the diff

@@ -370,6 +371,7 @@ runGenesisCreateTestNetDataCmd
{ L.drepExpiry = EpochNo 1_000
, L.drepAnchor = SNothing
, L.drepDeposit = max (L.Coin 1_000_000) minDeposit
, L.drepDelegs = Set.empty
Copy link
Contributor

@carbolymer carbolymer Oct 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@smelc wdyt?
Not a blocker for mainnet release anyway.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this the list of credentials delegating this drep? If that's the case, this shouldn't be Set.empty.

This shouldn't block releasing to mainnet indeed, but if this is wrong this could make cardano-testnet's tests fail.

@crocodile-dentist crocodile-dentist force-pushed the mwojtowicz/integrate-plutus-and-ledger-for-10.0 branch from fbaf02e to 37b1496 Compare October 17, 2024 08:54
@carbolymer
Copy link
Contributor

Updated pr description since this is a breaking change (major dependency upgrade)

@carbolymer carbolymer added this pull request to the merge queue Oct 17, 2024
Merged via the queue into main with commit 4260abf Oct 17, 2024
26 of 28 checks passed
@carbolymer carbolymer deleted the mwojtowicz/integrate-plutus-and-ledger-for-10.0 branch October 17, 2024 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants