Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it build with ghc-9.10 #1856

Merged
merged 6 commits into from
Oct 28, 2024
Merged

Make it build with ghc-9.10 #1856

merged 6 commits into from
Oct 28, 2024

Conversation

erikd
Copy link
Contributor

@erikd erikd commented Sep 12, 2024

Description

Add your description here, if it fixes a particular issue please provide a link to the issue.

Checklist

  • Commit sequence broadly makes sense
  • Commits have useful messages
  • New tests are added if needed and existing tests are updated
  • Any changes are noted in the changelog
  • Code is formatted with fourmolu on version 0.10.1.0 (which can be run with scripts/fourmolize.sh)
  • Self-reviewed the diff

Migrations

  • The pr causes a breaking change of type a,b or c
  • If there is a breaking change, the pr includes a database migration and/or a fix process for old values, so that upgrade is possible
  • Resyncing and running the migrations provided will result in the same database semantically

If there is a breaking change, especially a big one, please add a justification here. Please elaborate
more what the migration achieves, what it cannot achieve or why a migration is not possible.

@erikd
Copy link
Contributor Author

erikd commented Sep 12, 2024

Tried to add ghc-9.10 to the build matrix, but that version does not seem to exist in the support GHC versions with the way CI is set up.

@erikd erikd force-pushed the erikd/ghc-9.10 branch 2 times, most recently from 7d471a4 to 52e854d Compare September 18, 2024 21:23
@erikd erikd force-pushed the erikd/ghc-9.10 branch 2 times, most recently from a7972bb to f235f72 Compare October 1, 2024 20:57
@erikd erikd force-pushed the erikd/ghc-9.10 branch 2 times, most recently from 5413cf5 to a9fdf46 Compare October 13, 2024 23:54
@angerman
Copy link
Contributor

Questions I have:

  • Do we really need the shell? Can we just use the DevX shell? I guess @sgillespie might have an idea about this.
  • Must we pin the cabal version? Or can we just go with cabal = {}?

@angerman
Copy link
Contributor

As @hamishmack pointed out in #1873, @sgillespie bumped cabal. I think we should combine this and #1873? @sgillespie, @erikd what do you think?

@angerman
Copy link
Contributor

Let me reiterate my point about the version:

I'd rather just go with latest, that seems more robust.
and if we must pin a version have a clear comment that states why we pin the version.

@sgillespie
Copy link
Contributor

Since adding GHC-9.10 to the GH action is ongoing, I'd like to go ahead and get this merged into master. We can add back the entry in the build matrix after we fix devx

@sgillespie sgillespie merged commit 261cabf into master Oct 28, 2024
16 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants