Improve offchain #1860
Open
Improve offchain #1860
+81
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Needs testing |
sgillespie
reviewed
Sep 25, 2024
| httpGetOffChainVoteData gateways vurl metaHash anchorType = do | ||
| case useIpfsGatewayMaybe vurl gateways of | ||
| Nothing -> httpGetOffChainVoteDataSingle vurl metaHash anchorType | ||
| Just [] -> left $ OCFErrNoIpfsGateway (OffChainVoteUrl vurl) |
There was a problem hiding this comment.
Why not just make this a NonEmpty?
sgillespie
reviewed
Sep 25, 2024
| @@ -103,6 +104,7 @@ syncNodeConfig loggingCfg = | |||
| <*> triggerHardFork | |||
| <*> triggerHardFork | |||
| <*> syncInsertOptions | |||
| <*> pure [] | |||
There was a problem hiding this comment.
It would probably be useful to generate ipfs_gateway values
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add your description here, if it fixes a particular issue please provide a link to the issue.
Checklist
fourmoluon version 0.10.1.0 (which can be run withscripts/fourmolize.sh)Migrations
If there is a breaking change, especially a big one, please add a justification here. Please elaborate
more what the migration achieves, what it cannot achieve or why a migration is not possible.