Add more tests for voting behaviour #4603
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lucsanszky
force-pushed
the
ldan/voting-tests
branch
6 times, most recently
from
da55054
to
7932cd6
Compare
|
I recommend reviewing commit-by-commit so the refactoring commit doesn't get in your way. |
Lucsanszky
force-pushed
the
ldan/voting-tests
branch
2 times, most recently
from
31278fa
to
40d01a5
Compare
teodanciu
approved these changes
Sep 27, 2024
eras/conway/impl/testlib/Test/Cardano/Ledger/Conway/Imp/RatifySpec.hs
Outdated
Show resolved
Hide resolved
eras/conway/impl/testlib/Test/Cardano/Ledger/Conway/Imp/RatifySpec.hs
Outdated
Show resolved
Hide resolved
eras/conway/impl/testlib/Test/Cardano/Ledger/Conway/Imp/RatifySpec.hs
Outdated
Show resolved
Hide resolved
Lucsanszky
force-pushed
the
ldan/voting-tests
branch
6 times, most recently
from
692c40a
to
64cf83c
Compare
Lucsanszky
force-pushed
the
ldan/voting-tests
branch
2 times, most recently
from
0ad415a
to
b01b1e3
Compare
* Test basic interaction between the governing bodies:
- Motion of no-confidence
- Update committee - normal state
- Hard-fork initiation
- Thresholds are set to 0 for all governing bodies,
thus proposals are enacted automatically
Lucsanszky
force-pushed
the
ldan/voting-tests
branch
from
b01b1e3
to
c0f5a0f
Compare
* Assert that they won't be able to serve when `maxTermLength = 0` * Assert that they can serve a term when `maxTermLength = 1` Resolves #4513
* Test when CC is expired:
- SPOs alone can't enact hard-fork (thus getting stuck in bootstrap phase)
- SPOs alone can't enact security group parameter change
* Test when CC threshold is 0:
- SPOs alone can enact hard-fork
- SPOs alone can enact security group parameter change
Lucsanszky
force-pushed
the
ldan/voting-tests
branch
from
c0f5a0f
to
e3eab9a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves #4326, #4513
Checklist
CHANGELOG.mdfor the affected packages.New section is never added with the code changes. (See RELEASING.md)
.cabalandCHANGELOG.mdfiles according to theversioning process.
.cabalfiles for all affected packages are updated.If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)
fourmolu(usescripts/fourmolize.sh)scripts/cabal-format.sh)hie.yamlhas been updated (usescripts/gen-hie.sh)