Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cardano ledger conway 1.16.2.0 #4644

Merged
merged 10 commits into from
Sep 23, 2024
Merged

Cardano ledger conway 1.16.2.0 #4644

merged 10 commits into from
Sep 23, 2024

Conversation

lehins
Copy link
Collaborator

@lehins lehins commented Sep 23, 2024

Description

Backport of #4600 and #4643

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated
  • All visible changes are prepended to the latest section of a CHANGELOG.md for the affected packages.
    New section is never added with the code changes. (See RELEASING.md)
  • When applicable, versions are updated in .cabal and CHANGELOG.md files according to the
    versioning process.
  • The version bounds in .cabal files for all affected packages are updated.
    If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)
  • Code is formatted with fourmolu (use scripts/fourmolize.sh)
  • Cabal files are formatted (use scripts/cabal-format.sh)
  • hie.yaml has been updated (use scripts/gen-hie.sh)
  • Self-reviewed the diff

@lehins
Avoid passing arguments that are available in scope
023eb8e
@lehins
Further simplification of stake credential registration
49b02f1
@lehins
Consistent order of checks
f997e23
@lehins
Avoid complex comment by switching to UMap.insert
fd9b513
@lehins
Stop checking refunds when stake credential is not registered
6f4bb37 
It has been noticed that currently we report invalid refunds, even the
stake credential is not registered. This makes little sense, so this
commit changes this behavior.
@lehins
Avoid redundant lookups in the UMap for ConwayUnRegCert
cf46719
@lehins
Move the rest of the where bindings into let
6f08a48 
* Which allows is to avoid passing redundant arguments
* Switch to pointfree style and avoid using same name fo rthe umap that
  is being modified
@lehins
Move committeeUpdateContainsColdCred into let binding for consistency
c3bfd5c
@lehins
Improve performance of domDeleteAll and add extractStakingCredential
5e503c1
@lehins
Changelogs and version bumps
052d073
@lehins lehins changed the title Lehins/cardano ledger conway 1.16.2.0 Cardano ledger conway 1.16.2.0 Sep 23, 2024
TimSheard
TimSheard approved these changes Sep 23, 2024
View reviewed changes
Copy link
Contributor

@TimSheard TimSheard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

be sure the added comments of 4643 get forwarded to here.

eras/conway/impl/src/Cardano/Ledger/Conway/Rules/Deleg.hs Show resolved Hide resolved
Lucsanszky
Lucsanszky approved these changes Sep 23, 2024
View reviewed changes
Copy link
Contributor

@Lucsanszky Lucsanszky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Version bumps and CHANGELOG entries are correct too. 👍

@lehins lehins mentioned this pull request Sep 23, 2024
Merged
@lehins lehins merged commit cc8cb9e into release/cardano-ledger-conway-1.16.1.0 Sep 23, 2024
151 of 155 checks passed
@lehins lehins deleted the lehins/cardano-ledger-conway-1.16.2.0 branch September 23, 2024 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TimSheard TimSheard TimSheard approved these changes

@Lucsanszky Lucsanszky Lucsanszky approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lehins @TimSheard @Lucsanszky