Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't return ZeroTreasuryWithdrawals failure during bootstrap #4646

Merged
merged 1 commit into from
Sep 25, 2024

Conversation

teodanciu
Copy link
Contributor

and run withdrawal tests for both bootstrap and post-bootstrap

While reviewing Aniket's PR, I realized that in my previous PR, i have changed the behavior of empty withdrawals happening during bootstrap, by returning an extra predicate failure, which breaks node-to-client protocol.

This PR is changing that, ensuring that during bootstrap the new predicate failure is omitted, and also makes sure that withdrawal tests are executing for both protocol versions of Conway, to make sure that the predicate failures during bootstrap are kept unchanged.

Description

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated
  • All visible changes are prepended to the latest section of a CHANGELOG.md for the affected packages.
    New section is never added with the code changes. (See RELEASING.md)
  • When applicable, versions are updated in .cabal and CHANGELOG.md files according to the
    versioning process.
  • The version bounds in .cabal files for all affected packages are updated.
    If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)
  • Code is formatted with fourmolu (use scripts/fourmolize.sh)
  • Cabal files are formatted (use scripts/cabal-format.sh)
  • hie.yaml has been updated (use scripts/gen-hie.sh)
  • Self-reviewed the diff

@teodanciu teodanciu requested a review from a team as a code owner September 24, 2024 18:48
@teodanciu teodanciu force-pushed the td/fix-empty-withdrawals-pred-failure branch from 8b44b36 to 65ccc93 Compare September 24, 2024 18:49
and run withdrawal tests for both bootstrap and post-bootstrap
@lehins lehins force-pushed the td/fix-empty-withdrawals-pred-failure branch from 65ccc93 to 9f66649 Compare September 24, 2024 23:06
Copy link
Collaborator

@lehins lehins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍
Thank you for catching and fixing this issue

@lehins lehins merged commit ed804de into master Sep 25, 2024
152 of 154 checks passed
@lehins lehins deleted the td/fix-empty-withdrawals-pred-failure branch September 25, 2024 01:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants