Enhance Tracing with New Metrics, Renames, and Fixes #5991
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jutaro
force-pushed
the
jutaro/metrics_fixes
branch
from
3386501
to
7d478ca
Compare
jutaro
force-pushed
the
jutaro/metrics_fixes
branch
2 times, most recently
from
2b001c1
to
c84c8fc
Compare
jutaro
force-pushed
the
jutaro/metrics_fixes
branch
2 times, most recently
from
1fc970f
to
98e1751
Compare
jutaro
force-pushed
the
jutaro/metrics_fixes
branch
from
98e1751
to
bdd61e0
Compare
jutaro
changed the title
rename P2P metrics Forge metrics and CDFCounters fetch metrics fix for client metrics With forks metrics Churn Action duration metrics doc
jutaro
force-pushed
the
jutaro/metrics_fixes
branch
from
41641af
to
d833fa1
Compare
mgmeier
reviewed
Nov 7, 2024
mgmeier
approved these changes
Nov 8, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Summary
This PR introduces several enhancements and bug fixes to the new tracing system, including two additional metrics, improved naming consistency, and bug fixes to align with the legacy tracing system.
These additions and fixes are introduced to:
served.block.latestand other core metrics from the legacy system.New Metrics Added
node.start.time: Captures the node’s start time in POSIX seconds for machine use, providing a standardized timestamp for node initialization.served.block.latest: A legacy metric previously missing from the new system, now incorporated to track the latest served block and ensure compatibility with established monitoring workflows.Changes and Fixes