Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cardano-node 10.0 release #5998

Merged
merged 7 commits into from
Oct 18, 2024
Merged

cardano-node 10.0 release #5998

merged 7 commits into from
Oct 18, 2024

Conversation

crocodile-dentist
Copy link
Contributor

@crocodile-dentist crocodile-dentist commented Sep 26, 2024 •
edited
Loading

Description

  • Integrates Plutus 1.36 and related ledger changes for Chang 2 HF.
  • Removes legacy P2P topology format
  • Supports new NodeToNodeV_14 network version to identify adoption rate and NodeToClientV_18 for new query support.
  • Other minor changes

closes #5978
CHaP PR

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. These may include:
    • golden tests
    • property tests
    • roundtrip tests
    • integration tests
      See Runnings tests for more details
  • Any changes are noted in the CHANGELOG.md for affected package
  • The version bounds in .cabal files are updated
  • CI passes. See note on CI. The following CI checks are required:
    • Code is linted with hlint. See .github/workflows/check-hlint.yml to get the hlint version
    • Code is formatted with stylish-haskell. See .github/workflows/stylish-haskell.yml to get the stylish-haskell version
    • Code builds on Linux, MacOS and Windows for ghc-8.10.7 and ghc-9.2.7
  • Self-reviewed the diff

Note on CI

If your PR is from a fork, the necessary CI jobs won't trigger automatically for security reasons.
You will need to get someone with write privileges. Please contact IOG node developers to do this
for you.

@crocodile-dentist crocodile-dentist requested a review from a team as a code owner September 26, 2024 16:40
@crocodile-dentist crocodile-dentist marked this pull request as draft September 26, 2024 16:40
@crocodile-dentist crocodile-dentist force-pushed the mwojtowicz/release/node-9.3 branch 11 times, most recently from 78e9c2d to 9a2a745 Compare October 1, 2024 09:41
@crocodile-dentist crocodile-dentist force-pushed the mwojtowicz/release/node-9.3 branch 3 times, most recently from 12d69ea to b065626 Compare October 1, 2024 14:19
@crocodile-dentist crocodile-dentist force-pushed the mwojtowicz/release/node-9.3 branch 7 times, most recently from bfc826c to 0969a7e Compare October 4, 2024 17:09
@crocodile-dentist crocodile-dentist changed the title cardano-node 9.3.0 release cardano-node 10.0 release Oct 10, 2024
@crocodile-dentist crocodile-dentist force-pushed the mwojtowicz/release/node-9.3 branch 3 times, most recently from 19cc309 to c7bfd42 Compare October 10, 2024 14:40
carbolymer
carbolymer approved these changes Oct 18, 2024
View reviewed changes
Copy link
Contributor

@carbolymer carbolymer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻 for cardano-testnet changes

@crocodile-dentist crocodile-dentist force-pushed the mwojtowicz/release/node-9.3 branch 2 times, most recently from cbf3d9b to f7f8964 Compare October 18, 2024 11:24
Jimbo4350
Jimbo4350 approved these changes Oct 18, 2024
View reviewed changes
Copy link
Contributor

@Jimbo4350 Jimbo4350 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

cardano-node/src/Cardano/Node/Protocol/Cardano.hs Show resolved Hide resolved
cardano-testnet/test/cardano-testnet-test/Cardano/Testnet/Test/Gov/CommitteeAddNew.hs Show resolved Hide resolved
@crocodile-dentist crocodile-dentist dismissed bolt12’s stale review October 18, 2024 14:33

I've addressed all your comments, but github prevents me from merging because of something outstanding.

@crocodile-dentist crocodile-dentist added this pull request to the merge queue Oct 18, 2024
@crocodile-dentist crocodile-dentist removed this pull request from the merge queue due to a manual request Oct 18, 2024
@crocodile-dentist crocodile-dentist force-pushed the mwojtowicz/release/node-9.3 branch 2 times, most recently from 14ef4cc to 0c0889d Compare October 18, 2024 15:03
@crocodile-dentist crocodile-dentist mentioned this pull request Oct 18, 2024
Merged
crocodile-dentist and others added 7 commits October 18, 2024 19:08
@crocodile-dentist @carbolymer
Release 10.0
0631c8a 
* update hackage and fix index-state

plutus-ledger-api: disable haddock

Pin the haskell.nix flake input for GHC 8.10 support

Co-authored-by: Mateusz Galazyn <[email protected]>
@Jimbo4350 @carbolymer @crocodile-dentist
Update calls to cardano-cli due to recently removed commands
0b05057 
Add stake address registration to the tests

Co-authored-by: Mateusz Galazyn <[email protected]>
@crocodile-dentist
Remove support for legacy p2p topology format
326f9fb 
hlint: address issues
@crocodile-dentist
Integrate api changes
196f032
@crocodile-dentist
NodeToNodeVersion update
b09e725 
* Remove support for NodeToNodeV_12 and older
* Add support for NodeToNodeV_14 to track adoption rate
  of Chang +1 HF
@karknu @crocodile-dentist
Tracing updates
2f8020a 
Improve DebugState tracing

Add tracing for current ledgerStateJudgement and associationMode.

Add TraceMempoolSynced support

Add support for tracing TraceMempoolSynced along with a txsSyncDuration
which tracks how long it took to sync the mempool after block adoption.
Unit is ms.
@crocodile-dentist
Bump versions and update changelogs
1abdd47
@crocodile-dentist crocodile-dentist added this pull request to the merge queue Oct 18, 2024
Merged via the queue into master with commit cdb45dd Oct 18, 2024
27 of 31 checks passed
@crocodile-dentist crocodile-dentist deleted the mwojtowicz/release/node-9.3 branch October 18, 2024 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bolt12 bolt12 bolt12 left review comments

@Jimbo4350 Jimbo4350 Jimbo4350 approved these changes

@carbolymer carbolymer carbolymer approved these changes

Assignees

@crocodile-dentist crocodile-dentist

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Release: cardano-node 10.0
5 participants
@crocodile-dentist @carbolymer @Jimbo4350 @bolt12 @karknu