Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cardano-testnet | Add stake address registration/deregistration test #6017

Merged
merged 6 commits into from
Oct 28, 2024
Merged

cardano-testnet | Add stake address registration/deregistration test #6017

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
4ca29e2
cardano-testnet | Refactor: use default key deposit from defaultShell…
carbolymer Oct 23, 2024
a29bd5d
cardano-testnet | Add stake registration & deregistration test
carbolymer Oct 23, 2024
b092ee3
cardano-testnet | Refactor: use KeyPair in registerSingleSpo
carbolymer Oct 21, 2024
f557aeb
cardano-testnet | Refactor: Remove SomeKeyPair
carbolymer Oct 22, 2024
0e9b91e
cardano-testnet | Refactor: remove remaining hardcoded key deposits
carbolymer Oct 22, 2024
6fa52d3
cardano-testnet | Refactor: use function for creating registration ce…
carbolymer Oct 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
85 changes: 43 additions & 42 deletions cardano-testnet/src/Testnet/Process/Cli/SPO.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,10 +52,10 @@ checkStakePoolRegistered
:: (MonadTest m, MonadCatch m, MonadIO m, HasCallStack)
=> TmpAbsolutePath
-> ExecConfig
-> FilePath -- ^ Stake pool cold verification key file
-> File (VKey StakeKey) In -- ^ Stake pool cold verification key file
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be helpful to include the fact that this is a cold key in the type.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, that's a typo. I've used StakePoolKey type instead in #6026

-> FilePath -- ^ Output file path of stake pool info
-> m String -- ^ Stake pool ID
checkStakePoolRegistered tempAbsP execConfig poolColdVkeyFp outputFp =
checkStakePoolRegistered tempAbsP execConfig (File poolColdVkeyFp) outputFp =
GHC.withFrozenCallStack $ do
let tempAbsPath' = unTmpAbsPath tempAbsP
oFpAbs = tempAbsPath' </> outputFp
Expand Down Expand Up @@ -160,11 +160,11 @@ createStakeDelegationCertificate
:: (MonadTest m, MonadCatch m, MonadIO m, HasCallStack)
=> TmpAbsolutePath
-> ShelleyBasedEra era
-> FilePath -- ^ Delegate stake verification key file
-> File (VKey StakeKey) In -- ^ Delegate stake verification key file
-> String -- ^ Pool id
-> FilePath
-> m ()
createStakeDelegationCertificate tempAbsP sbe delegatorStakeVerKey poolId outputFp =
createStakeDelegationCertificate tempAbsP sbe (File delegatorStakeVerKey) poolId outputFp =
GHC.withFrozenCallStack $ do
let tempAbsPath' = unTmpAbsPath tempAbsP
execCli_
Expand All @@ -179,11 +179,11 @@ createStakeKeyRegistrationCertificate
:: (MonadTest m, MonadCatch m, MonadIO m, HasCallStack)
=> TmpAbsolutePath
-> AnyShelleyBasedEra
-> FilePath -- ^ Stake verification key file
-> File (VKey StakeKey) In -- ^ Stake verification key file
-> Int -- ^ deposit amount used only in Conway
-> FilePath -- ^ Output file path
-> m ()
createStakeKeyRegistrationCertificate tempAbsP asbe stakeVerKey deposit outputFp = GHC.withFrozenCallStack $ do
createStakeKeyRegistrationCertificate tempAbsP asbe (File stakeVerKey) deposit outputFp = GHC.withFrozenCallStack $ do
AnyShelleyBasedEra sbe <- return asbe
let tempAbsPath' = unTmpAbsPath tempAbsP
extraArgs = monoidForEraInEon @ConwayEraOnwards (toCardanoEra sbe) $
Expand Down Expand Up @@ -251,16 +251,12 @@ registerSingleSpo
-> ExecConfig
-> (TxIn, FilePath, String)
-> m ( String
, FilePath
, FilePath
, FilePath
, FilePath
, KeyPair StakeKey
, KeyPair VrfKey
) -- ^ Result tuple:
-- 1. String: Registered stake pool ID
-- 2. FilePath: Stake pool cold signing key
-- 3. FilePath: Stake pool cold verification key
-- 4. FilePath: Stake pool VRF signing key
-- 5. FilePath: Stake pool VRF verification key
-- 2. Stake pool cold keys
-- 3. Stake pool VRF keys
registerSingleSpo asbe identifier tap@(TmpAbsolutePath tempAbsPath') nodeConfigFile socketPath termEpoch testnetMag execConfig
(fundingInput, fundingSigninKey, changeAddr) = GHC.withFrozenCallStack $ do
workDir <- H.note tempAbsPath'
Expand All @@ -276,48 +272,53 @@ registerSingleSpo asbe identifier tap@(TmpAbsolutePath tempAbsPath') nodeConfigF
let spoReqDir = workDir </> "spo-"<> show identifier <> "-requirements"

H.createDirectoryIfMissing_ spoReqDir
let poolOwnerstakeVkeyFp = spoReqDir </> "pool-owner-stake.vkey"
poolOwnerstakeSKeyFp = spoReqDir </> "pool-owner-stake.skey"
let poolOwnerStakeKeys = KeyPair
{ verificationKey = File $ spoReqDir </> "pool-owner-stake.vkey"
, signingKey = File $ spoReqDir </> "pool-owner-stake.skey"
}

cliStakeAddressKeyGen
$ KeyPair (File poolOwnerstakeVkeyFp) (File poolOwnerstakeSKeyFp)
cliStakeAddressKeyGen poolOwnerStakeKeys

poolownerstakeaddr <- filter (/= '\n')
<$> execCli
[ "latest", "stake-address", "build"
, "--stake-verification-key-file", poolOwnerstakeVkeyFp
, "--stake-verification-key-file", verificationKeyFp poolOwnerStakeKeys
, "--testnet-magic", show @Int testnetMag
]

-- 2. Generate stake pool owner payment key pair
let poolOwnerPaymentVkeyFp = spoReqDir </> "pool-owner-payment.vkey"
poolOwnerPaymentSkeyFp = spoReqDir </> "pool-owner-payment.skey"
cliAddressKeyGen
$ KeyPair (File poolOwnerPaymentVkeyFp) (File poolOwnerPaymentSkeyFp)
let poolOwnerPaymentKeys = KeyPair
{ verificationKey = File $ spoReqDir </> "pool-owner-payment.vkey"
, signingKey = File $ spoReqDir </> "pool-owner-payment.skey"
}
cliAddressKeyGen poolOwnerPaymentKeys

poolowneraddresswstakecred <-
execCli [ "latest", "address", "build"
, "--payment-verification-key-file", poolOwnerPaymentVkeyFp
, "--stake-verification-key-file", poolOwnerstakeVkeyFp
, "--payment-verification-key-file", verificationKeyFp poolOwnerPaymentKeys
, "--stake-verification-key-file", verificationKeyFp poolOwnerStakeKeys
, "--testnet-magic", show @Int testnetMag
]

-- 3. Generate pool cold keys
let poolColdVkeyFp = spoReqDir </> "pool-cold.vkey"
poolColdSkeyFp = spoReqDir </> "pool-cold.skey"
let poolColdKeys = KeyPair
{ verificationKey = File $ spoReqDir </> "pool-cold.vkey"
, signingKey = File $ spoReqDir </> "pool-cold.skey"
}

execCli_
[ "latest", "node", "key-gen"
, "--cold-verification-key-file", poolColdVkeyFp
, "--cold-signing-key-file", poolColdSkeyFp
, "--cold-verification-key-file", verificationKeyFp poolColdKeys
, "--cold-signing-key-file", signingKeyFp poolColdKeys
, "--operational-certificate-issue-counter-file", spoReqDir </> "operator.counter"
]

-- 4. Generate VRF keys
let vrfVkeyFp = spoReqDir </> "pool-vrf.vkey"
vrfSkeyFp = spoReqDir </> "pool-vrf.skey"
cliNodeKeyGenVrf
$ KeyPair (File vrfVkeyFp) (File vrfSkeyFp)
let vrfKeys = KeyPair
{ verificationKey = File $ spoReqDir </> "pool-vrf.vkey"
, signingKey = File $ spoReqDir </> "pool-vrf.skey"
}
cliNodeKeyGenVrf vrfKeys

-- 5. Create registration certificate
let poolRegCertFp = spoReqDir </> "registration.cert"
Expand All @@ -330,10 +331,10 @@ registerSingleSpo asbe identifier tap@(TmpAbsolutePath tempAbsPath') nodeConfigF
, "--pool-pledge", "0"
, "--pool-cost", "0"
, "--pool-margin", "0"
, "--cold-verification-key-file", poolColdVkeyFp
, "--vrf-verification-key-file", vrfVkeyFp
, "--reward-account-verification-key-file", poolOwnerstakeVkeyFp
, "--pool-owner-stake-verification-key-file", poolOwnerstakeVkeyFp
, "--cold-verification-key-file", verificationKeyFp poolColdKeys
, "--vrf-verification-key-file", verificationKeyFp vrfKeys
, "--reward-account-verification-key-file", verificationKeyFp poolOwnerStakeKeys
, "--pool-owner-stake-verification-key-file", verificationKeyFp poolOwnerStakeKeys
, "--out-file", poolRegCertFp
]

Expand All @@ -342,7 +343,7 @@ registerSingleSpo asbe identifier tap@(TmpAbsolutePath tempAbsPath') nodeConfigF

-- Create pledger registration certificate
createStakeKeyRegistrationCertificate tap asbe
poolOwnerstakeVkeyFp
(verificationKey poolOwnerStakeKeys)
400_000
carbolymer marked this conversation as resolved.
Show resolved Hide resolved
(workDir </> "pledger.regcert")

Expand All @@ -365,8 +366,8 @@ registerSingleSpo asbe identifier tap@(TmpAbsolutePath tempAbsPath') nodeConfigF
, "--tx-body-file", workDir </> "pledge-registration-cert.txbody"
, "--testnet-magic", show @Int testnetMag
, "--signing-key-file", fundingSigninKey
, "--signing-key-file", poolOwnerstakeSKeyFp
, "--signing-key-file", poolColdSkeyFp
, "--signing-key-file", signingKeyFp poolOwnerStakeKeys
, "--signing-key-file", signingKeyFp poolColdKeys
, "--out-file", pledgeAndPoolRegistrationTx
]

Expand Down Expand Up @@ -397,9 +398,9 @@ registerSingleSpo asbe identifier tap@(TmpAbsolutePath tempAbsPath') nodeConfigF
poolId <- checkStakePoolRegistered
tap
execConfig
poolColdVkeyFp
(verificationKey poolColdKeys)
currentRegistedPoolsJson
return (poolId, poolColdSkeyFp, poolColdVkeyFp, vrfSkeyFp, vrfVkeyFp)
return (poolId, poolColdKeys, vrfKeys)

-- | Generates Stake Pool Operator (SPO) voting files, using @cardano-cli@.
--
Expand Down
30 changes: 16 additions & 14 deletions cardano-testnet/test/cardano-testnet-test/Cardano/Testnet/Test/Cli/KesPeriodInfo.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,30 +112,32 @@ hprop_kes_period_info = integrationRetryWorkspace 2 "kes-period-info" $ \tempAbs
let testStakeDelegator = work </> "test-delegator"

H.createDirectoryIfMissing_ testStakeDelegator
let testDelegatorVkeyFp = testStakeDelegator </> "test-delegator.vkey"
testDelegatorSKeyFp = testStakeDelegator </> "test-delegator.skey"
testDelegatorPaymentVKeyFp = testStakeDelegator </> "test-delegator-payment.vkey"
testDelegatorPaymentSKeyFp = testStakeDelegator </> "test-delegator-payment.skey"
let testDelegatorKeys = KeyPair
{ signingKey = File $ testStakeDelegator </> "test-delegator.skey"
, verificationKey = File $ testStakeDelegator </> "test-delegator.vkey"
}
testDelegatorPaymentKeys = KeyPair
{ signingKey = File $ testStakeDelegator </> "test-delegator-payment.skey"
, verificationKey = File $ testStakeDelegator </> "test-delegator-payment.vkey"
}
testDelegatorRegCertFp = testStakeDelegator </> "test-delegator.regcert"
testDelegatorDelegCert = testStakeDelegator </> "test-delegator.delegcert"

cliStakeAddressKeyGen
$ KeyPair (File testDelegatorVkeyFp) (File testDelegatorSKeyFp)
cliAddressKeyGen
$ KeyPair (File testDelegatorPaymentVKeyFp) (File testDelegatorPaymentSKeyFp)
cliStakeAddressKeyGen testDelegatorKeys
cliAddressKeyGen testDelegatorPaymentKeys

-- NB: We must include the stake credential
testDelegatorPaymentAddr <- execCli
[ "latest", "address", "build"
, "--testnet-magic", show @Int testnetMagic
, "--payment-verification-key-file", testDelegatorPaymentVKeyFp
, "--stake-verification-key-file", testDelegatorVkeyFp
, "--payment-verification-key-file", verificationKeyFp testDelegatorPaymentKeys
, "--stake-verification-key-file", verificationKeyFp testDelegatorKeys
]
testDelegatorStakeAddress
<- filter (/= '\n')
<$> execCli
[ "latest", "stake-address", "build"
, "--stake-verification-key-file", testDelegatorVkeyFp
, "--stake-verification-key-file", verificationKeyFp testDelegatorKeys
, "--testnet-magic", show @Int testnetMagic
]

Expand All @@ -144,15 +146,15 @@ hprop_kes_period_info = integrationRetryWorkspace 2 "kes-period-info" $ \tempAbs
createStakeKeyRegistrationCertificate
tempAbsPath
(cardanoNodeEra cTestnetOptions)
testDelegatorVkeyFp
(verificationKey testDelegatorKeys)
keyDeposit
testDelegatorRegCertFp

-- Test stake address deleg cert
createStakeDelegationCertificate
tempAbsPath
sbe
testDelegatorVkeyFp
(verificationKey testDelegatorKeys)
stakePoolId
testDelegatorDelegCert

Expand Down Expand Up @@ -192,7 +194,7 @@ hprop_kes_period_info = integrationRetryWorkspace 2 "kes-period-info" $ \tempAbs
, "--tx-body-file", delegRegTestDelegatorTxBodyFp
, "--testnet-magic", show @Int testnetMagic
, "--signing-key-file", utxoSKeyFile
, "--signing-key-file", testDelegatorSKeyFp
, "--signing-key-file", signingKeyFp testDelegatorKeys
, "--out-file", delegRegTestDelegatorTxFp
]

Expand Down