Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: 🎃 #2270

Merged
merged 1 commit into from
Oct 31, 2024
Merged

feat: 🎃 #2270

merged 1 commit into from
Oct 31, 2024

Conversation

Ryun1
Copy link
Member

@Ryun1 Ryun1 commented Oct 29, 2024

List of changes

  • Add / Fix / Change / Remove

Checklist

  • related issue
  • My changes generate no new warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the changelog
  • I have added tests that prove my fix is effective or that my feature works

@github-actions GitHub Actions
Copy link

✅ All checks succeeded

2 similar comments
@github-actions GitHub Actions
Copy link

✅ All checks succeeded

@github-actions GitHub Actions
Copy link

✅ All checks succeeded

@Ryun1 Ryun1 changed the title feat: replace hero image with jack o lantern feat: 🎃 Oct 29, 2024
@MSzalowski
Copy link
Contributor

Is it for real? 🙈

@Ryun1
Copy link
Member Author

Ryun1 commented Oct 29, 2024

@MSzalowski I think we can do it for two days? 😆 will be fun

@m-i-k-e
Copy link

m-i-k-e commented Oct 29, 2024

@Ryun1 @MSzalowski We need a PR to undo this as well.

@Ryun1 Ryun1 marked this pull request as ready for review October 30, 2024 10:45
@Ryun1 Ryun1 requested a review from MSzalowski as a code owner October 30, 2024 10:45
MSzalowski
MSzalowski approved these changes Oct 30, 2024
View reviewed changes
Copy link
Contributor

@MSzalowski MSzalowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎃 🔥

@MSzalowski MSzalowski merged commit 431270a into develop Oct 31, 2024
9 checks passed
@MSzalowski MSzalowski deleted the fun/replace-hero-image-with-jack-o-lantern branch October 31, 2024 09:39
@github-actions GitHub Actions
Copy link

@Ryun1
This PR is in the tag: develop-431270aa4019626f87c0405db2f34f343c072839 , for govtool-metadata-validation service

@github-actions GitHub Actions
Copy link

@Ryun1
This PR is in the tag: develop-431270aa4019626f87c0405db2f34f343c072839 , for govtool-frontend service

@github-actions GitHub Actions
Copy link

@Ryun1
This PR is in the tag: develop-431270aa4019626f87c0405db2f34f343c072839 , for govtool-backend service

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bosko-m bosko-m bosko-m approved these changes

@MSzalowski MSzalowski MSzalowski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Ryun1 @MSzalowski @m-i-k-e @bosko-m